Update broadcast_arrays to return a tuple instead of a list #2944
Update broadcast_arrays to return a tuple instead of a list #2944vlad-perevezentsev wants to merge 4 commits into
broadcast_arrays to return a tuple instead of a list #2944Conversation
vlad-perevezentsev
requested review from
antonwolfy and
ndgrigorian
as code owners
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2944/index.html |
|
coverage: 78.251% (+0.003%) from 78.248% — return_tuple_broadcast_arrays into master |
|
Array API standard conformance tests for dpnp=0.21.0dev0=py313h509198e_70 ran successfully. |
|
|
||
| def test_broadcast_arrays_empty_input(self): | ||
| assert dpnp.broadcast_arrays() == [] | ||
| assert dpnp.broadcast_arrays() == () |
There was a problem hiding this comment.
Seems we don't have an explicit type assertion in any tensor or dpnp tests, excluding use case with empty input.
| @@ -289,7 +289,7 @@ def test_incompatible_shapes_raise_valueerror(self, shapes): | |||
| self.assert_broadcast_arrays_raise(input_shapes[::-1]) | |||
|
|
|||
| def test_broadcast_arrays_empty_input(self): | |||
There was a problem hiding this comment.
Missed to update dpnp/tests/third_party/cupy/manipulation_tests/test_dims.py with the latest changed (including new test added there for that use case)
| * Replaced `.pxi` includes in `dpnp.tensor` with modular `.pxd`/`.pyx` Cython imports [#2913](https://github.com/IntelPython/dpnp/pull/2913) | ||
| * Reimplemented `dpnp.eye` and `dpnp.tensor.eye` with a branchless kernel [gh-2937](https://github.com/IntelPython/dpnp/pull/2937) | ||
| * Cleaned up Python bindings for indexing functions, renaming `usm_ndarray_take` and `usm_ndarray_put` to `py_take` and `py_put` and refactoring validation [gh-2935](https://github.com/IntelPython/dpnp/pull/2935) | ||
| * Changed `dpnp.broadcast_arrays` and `dpnp.tensor.broadcast_arrays` to return a tuple instead of a list, aligning with NumPy 2.x behavior and 2025.12 version of the Python array API standard [#2944](https://github.com/IntelPython/dpnp/pull/2944) |
There was a problem hiding this comment.
What do you mean by NumPy 2.x? Is it known where it will be done? NumPy 2.5? Then should explicitly state that.
3 participants
This PR updates
dpnp.broadcast_arrays()anddpnp.tensor.broadcast_arrays()to return a tuple instead of a list aligning their behavior with the Python Array API 2025.12 and NumPy