twelite-stage 202508,R2 - #274940
Conversation
samford
left a comment
There was a problem hiding this comment.
Sorry it took so long for me to review this. I had started reviewing this weeks ago and I thought I submitted the review but evidently I didn't.
| regex(/href=.*?MWSTAGE(\d{6})_macOS_(R\d+)\.zip/i) | ||
| strategy :page_match do |page, regex| | ||
| page.scan(regex).map { |match| "#{match[0]},#{match[1]}" } |
There was a problem hiding this comment.
| regex(/href=.*?MWSTAGE(\d{6})_macOS_(R\d+)\.zip/i) | |
| strategy :page_match do |page, regex| | |
| page.scan(regex).map { |match| "#{match[0]},#{match[1]}" } | |
| regex(/href=.*?MWSTAGE[._-]?v?(\d+(?:[.-]\d+)*)[._-](?:macOS|osx)(?:[._-](R\d+))?\.zip/i) | |
| strategy :page_match do |page, regex| | |
| page.scan(regex).map do |match| | |
| match[1].present? ? "#{match[0]},#{match[1]}" : match[0] | |
| end |
Looking at previous releases, the "_R2" suffix isn't present in past releases, so this should be treated as an optional part of the version and file name in the url. There seems to be some variation in the file name format, so there's a chance that the regex may not match a new version if/when it appears but I've tweaked the regex to make it a little more flexible in hopes that will help.
| url "https://dist.twelite.net/sdk/MWSTAGE#{version.csv.first}_macOS_#{version.csv.second}.zip", | ||
| verified: "dist.twelite.net/sdk/" |
There was a problem hiding this comment.
| url "https://dist.twelite.net/sdk/MWSTAGE#{version.csv.first}_macOS_#{version.csv.second}.zip", | |
| verified: "dist.twelite.net/sdk/" | |
| url "https://twelite.net/DL/sdk/MWSTAGE#{version.csv.first}_macOS#{"_#{version.csv.second}" if version.csv.second}.zip" |
This updates the url to make the suffix for the second version part conditional but also updates it to use the current URL from the download page, as the dist.twelite.net host isn't resolving (something may have changed in the time since this PR was created and now).
| # includes source code and other user resources. | ||
| # It is neither an "app" nor a "suite". | ||
| artifact "MWSTAGE", target: "~/MWSTAGE" | ||
| artifact "MWSTAGE#{version.csv.first}_macOS_#{version.csv.second}", target: "~/MWSTAGE" |
There was a problem hiding this comment.
| artifact "MWSTAGE#{version.csv.first}_macOS_#{version.csv.second}", target: "~/MWSTAGE" | |
| artifact "MWSTAGE#{version.csv.first}_macOS#{"_#{version.csv.second}" if version.csv.second}", target: "~/MWSTAGE" |
After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.zapstanza paths.AI helped locate the current official download and update the cask. I manually verified the vendor's stable
202508_R2release, SHA-256 and archive integrity,brew audit,brew style, livecheck, and install/uninstall on macOS 26.5.1. I also confirmed the~/MWSTAGEzap path did not exist before testing and was created and removed by Homebrew as expected.Updates the cask to the vendor's corrected
202508_R2release and restores the livecheck. Addresses thetwelite-stagesource report in #172732.