Skip to content

twelite-stage 202508,R2 - #274940

Open
coyaSONG wants to merge 1 commit into
Homebrew:mainfrom
coyaSONG:agent/twelite-stage-202508-r2
Open

twelite-stage 202508,R2#274940
coyaSONG wants to merge 1 commit into
Homebrew:mainfrom
coyaSONG:agent/twelite-stage-202508-r2

Conversation

@coyaSONG

Copy link
Copy Markdown
Contributor

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes, including zap stanza paths.

AI helped locate the current official download and update the cask. I manually verified the vendor's stable 202508_R2 release, SHA-256 and archive integrity, brew audit, brew style, livecheck, and install/uninstall on macOS 26.5.1. I also confirmed the ~/MWSTAGE zap path did not exist before testing and was created and removed by Homebrew as expected.


Updates the cask to the vendor's corrected 202508_R2 release and restores the livecheck. Addresses the twelite-stage source report in #172732.

@coyaSONG
coyaSONG marked this pull request as ready for review July 14, 2026 11:04
@chenrui333 chenrui333 added the livecheck Issues or PRs related to livecheck. label Jul 14, 2026
@bevanjkay
bevanjkay requested a review from samford July 23, 2026 09:49
@bevanjkay
bevanjkay enabled auto-merge August 4, 2026 03:25

@samford samford left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long for me to review this. I had started reviewing this weeks ago and I thought I submitted the review but evidently I didn't.

Comment thread Casks/t/twelite-stage.rb
Comment on lines +13 to +15
regex(/href=.*?MWSTAGE(\d{6})_macOS_(R\d+)\.zip/i)
strategy :page_match do |page, regex|
page.scan(regex).map { |match| "#{match[0]},#{match[1]}" }

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
regex(/href=.*?MWSTAGE(\d{6})_macOS_(R\d+)\.zip/i)
strategy :page_match do |page, regex|
page.scan(regex).map { |match| "#{match[0]},#{match[1]}" }
regex(/href=.*?MWSTAGE[._-]?v?(\d+(?:[.-]\d+)*)[._-](?:macOS|osx)(?:[._-](R\d+))?\.zip/i)
strategy :page_match do |page, regex|
page.scan(regex).map do |match|
match[1].present? ? "#{match[0]},#{match[1]}" : match[0]
end

Looking at previous releases, the "_R2" suffix isn't present in past releases, so this should be treated as an optional part of the version and file name in the url. There seems to be some variation in the file name format, so there's a chance that the regex may not match a new version if/when it appears but I've tweaked the regex to make it a little more flexible in hopes that will help.

Comment thread Casks/t/twelite-stage.rb
Comment on lines +5 to +6
url "https://dist.twelite.net/sdk/MWSTAGE#{version.csv.first}_macOS_#{version.csv.second}.zip",
verified: "dist.twelite.net/sdk/"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url "https://dist.twelite.net/sdk/MWSTAGE#{version.csv.first}_macOS_#{version.csv.second}.zip",
verified: "dist.twelite.net/sdk/"
url "https://twelite.net/DL/sdk/MWSTAGE#{version.csv.first}_macOS#{"_#{version.csv.second}" if version.csv.second}.zip"

This updates the url to make the suffix for the second version part conditional but also updates it to use the current URL from the download page, as the dist.twelite.net host isn't resolving (something may have changed in the time since this PR was created and now).

Comment thread Casks/t/twelite-stage.rb
# includes source code and other user resources.
# It is neither an "app" nor a "suite".
artifact "MWSTAGE", target: "~/MWSTAGE"
artifact "MWSTAGE#{version.csv.first}_macOS_#{version.csv.second}", target: "~/MWSTAGE"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
artifact "MWSTAGE#{version.csv.first}_macOS_#{version.csv.second}", target: "~/MWSTAGE"
artifact "MWSTAGE#{version.csv.first}_macOS#{"_#{version.csv.second}" if version.csv.second}", target: "~/MWSTAGE"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

livecheck Issues or PRs related to livecheck.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants