mirai 0.4.6 (new cask)#263020
Conversation
bevanjkay
left a comment
There was a problem hiding this comment.
Do you have any insight into why the repository name is uzu, but the rest of the branding is Mirai?
Hi @bevanjkay! Thank you for the review. Mirai is the company name. We have a bunch of products, like an inference engine and a model conversion toolkit, but for end-user products, we prefer to use the company name for branding reasons. Regarding the other suggestions, what’s the proper way to handle them, should I make a separate commit, or open a new PR? |
What if you need to add one of the other projects to brew? I think this should be called |
You can add commits to this PR. I also agree with the comment above about using a prefixed token like |
Co-authored-by: Bevan Kay <bevanjkay@gmail.com>
I actually think the "mirai-uzu" option is a bit misleading, since this cli itself doesn’t mention uzu anywhere. For now, we’re going to have two user-facing products:
You can think of the uzu repo as a monorepo where, alongside the SDK, we also maintain a few user-facing products built on top of it. With each SDK release, those products are updated automatically as well. |
|
If people want to install what's in the repo called uzu, how will they know that nothing is called uzu and that they should search for the organization name instead? |
|
We will add an explicit brew install command to the README once it becomes available. In addition, the primary source for installation will not be GitHub, but the official website: https://trymirai.com |
From years of experience, that won't help. People will see the repo name and try and install it based on that. If you don't want something to be known under a certain name the best fix is not to name it that. |
|
@SMillerDev what do you think about combining both the CLI with Mirai branding and the Mirai macOS app into a single cask? The url would no longer point to GitHub release artifacts, but instead reference the installer from our S3 bucket. This way, the naming stays clear: people see the Mirai app on the website, install an app with the same name, and also get the CLI, which shows the Mirai logo when launched. |
|
If the app and the binary are served by the same |
After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.zapstanza paths.