feat(deadline): terminiert + reference DeadlineRule types#8
Merged
Conversation
DeadlineRule gains direction/anchor/recurring fields and two new types:
- 'terminiert': a spätester-ÜT/ÜZ deadline fixed relative to an external anchor
(Zahlungsziel, Änderungstermin, …) or recurring daily; rendered as a compact
inline tag ({≤20WT vor Änderungstermin}, {≤Zahlungsziel}, {täglich ≤14:00}).
- 'reference': a real but irreducible Frist (points to another table/SD/contract,
or is conditional/a range); rendered as an (i) note WITHOUT [REVIEW] so
extract_review_notes no longer surfaces it as 'Prüfung nötig'.
Markdown legend now lists only the marker kinds present on each diagram.
All fields optional/defaulted → existing rules deserialize unchanged.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The new terminiert/reference rendering introduced German words in src comments and Literal values that codespell mistakes for English typos. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1/3 of clearing the sequence-diagram Frist
[REVIEW]badges via a three-bucketdeadline scheme (design doc:
mako_prozesse/docs/plans/2026-07-02-frist-review-buckets-design.md).What
DeadlineRulegainsdirection/anchor/recurring(all optional → existing rowsdeserialize unchanged) and two new
typevalues:terminiert— a spätester-ÜT/ÜZ deadline fixed relative to an external anchor(
Zahlungsziel,Änderungstermin, …) or recurring daily._deadline_tagrenders acompact inline tag:
{≤20WT vor Änderungstermin},{≤Zahlungsziel},{täglich ≤14:00},{≤11WT nach #2}.reference— a real but irreducible Frist (points to another table/SD/contract, oris conditional/a range).
_deadline_noterenders it as an(i) Frist: …note without[REVIEW], soextract_review_notesno longer surfaces it as "Prüfung nötig".markdown.pylegend now lists only the marker kinds present on each diagram.Verification
152 passed, 1 skipped; mypy + pylint 10/10 on changed files.Ship dependency
The parser (
makorele) and webapp consume this. This must be released to PyPI first —makorelepinsmakoralle>=0.0.1from PyPI, so its companion PR only goes green against arelease that includes these types. Then: regenerate the dataset → bump
DATA_VERSIONinmako_prozesse.🤖 Generated with Claude Code