Add x-client - #17
Conversation
A tentative fix for the authorization issue
|
For the fix to be applied, we need to:
|
|
Hi @Majed6, thanks for the intervention here! It looks likely that this'll address the issue, but I'm concerned that the tests have started failing. Any idea why we'd be getting this? Possibly an issue with the Node version bump? |
|
Hey @SabreCat , Happy to help anytime! Thanks for taking a look at the PR. The bump is applied to deploy.yml. It's habitica setup that is failing. If you take a look at the test.yml file, you'll see that it tries to setup habitica's backend first. The failure is due to the outdated habitica's setup in this project. Most likely the use of ubuntu-latest default node 18 but it could be other things as well such as missing steps from the setup procedure for a habitica backend. It might require us to run habitica on a separate container or use a hosted version of habitica to simplify the setup. Given how stable Habitica's API is, a hosted version makes more since especially if we use production or a dev build that is maintained for other use cases. Both Zapier and Habitica integrations are the most stable services I've ever come across. Alternatively we could mock Habitica and separate both projects. I believe that updating the testing setup is bit beyond the scope of this PR. As it might not be an easy task. So I believe that it would be better to restore Zapier functionality by deploying the PR and creating a separate issue for test.yml. Let me know what you think. |
|
That makes sense to me. Here goes~ |
|
Merged and release created. I need to hunt down the credentials to get logged back into the Zapier config to check the secret -- nobody Habitica side has touched this since Alys departed the project some years ago, there was some knowledge lost there. That said, it's probably still valid? If you can give it a test run on your end and report if this has you back up and running, that'd be a great help! |
|
If it deployed then it's valid. Now the only thing left is to do is decide how to migrate users. You can do emails or percentage of users. Since any old version is broken then it would make sense to go 100%. I can share some ui pictures if you would like. |
|
I just tested scoring up a task and it worked. The beta version ( which probably the majority of users are using ) auto updated for me. The official version didn't. I don't know how many users does the official version have but I doubt it's as many since its link died before the beta link died. |
A tentative fix for the authorization issue