fix(grounding): mask line-leading ordered-list markers from number ex… - #1063
Open
zzz607 wants to merge 1 commit into
Open
fix(grounding): mask line-leading ordered-list markers from number ex…#1063zzz607 wants to merge 1 commit into
zzz607 wants to merge 1 commit into
Conversation
…traction Markdown ordered-list markers (e.g. "1. **标题**") were parsed as floats by _NUMBER_RE and rejected downstream as numeric_claim_conflict against the observed OHLC range. Add _MD_LIST_ITEM_RE and strip "^\s*\d+[.)]\s+" at the head of _numbers_without_dates_or_percent's mask chain, so list markers are removed at the number-extraction entry point across all numeric paths, not just price comparison. In-text decimals like 1.5 are unaffected (digit after the dot). Add tests in test_agent_grounding.py covering marker masking, conflict check not weakened, and in-text decimal survival.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…traction
Markdown ordered-list markers (e.g. "1. 标题") were parsed as floats by _NUMBER_RE and rejected downstream as numeric_claim_conflict against the observed OHLC range.
Add _MD_LIST_ITEM_RE and strip "^\s*\d+[.)]\s+" at the head of _numbers_without_dates_or_percent's mask chain, so list markers are removed at the number-extraction entry point across all numeric paths, not just price comparison. In-text decimals like 1.5 are unaffected (digit after the dot).
Add tests in test_agent_grounding.py covering marker masking, conflict check not weakened, and in-text decimal survival.
Summary
Why
Changes
Test Plan
pytest --ignore=agent/tests/e2e_backtest --tb=short -q)Checklist
src/agent/,src/session/,src/providers/) without prior discussion