fix(waiter): guard signal.signal() calls for non-main threads - #151
Open
eason-hk-barcelona wants to merge 2 commits into
Open
fix(waiter): guard signal.signal() calls for non-main threads#151eason-hk-barcelona wants to merge 2 commits into
eason-hk-barcelona wants to merge 2 commits into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signal.signal()calls inTaskWaiter.wait()with a main-thread check to preventValueErrorwhen the waiter runs inside a worker thread.Problem
TaskWaiter.wait()unconditionally callssignal.signal(signal.SIGINT, ...)to install a graceful-shutdown handler. Python requires thatsignal.signal()is only called from the main thread of the main interpreter — calling it elsewhere raises:This was not an issue when tasks ran serially, but breaks under parallel execution (e.g. MASP-Bench with
RUN_ALL_WORKERS=4), where the call chain becomes:Fix
Added a
threading.current_thread() is threading.main_thread()guard around signal handler installation and restoration. Whenwait()runs in a non-main thread, signal handling is simply skipped.Trade-off: Tasks running in worker threads cannot be gracefully interrupted via Ctrl+C — they must rely on timeout or explicit termination. This is an acceptable degradation since the core polling and task-completion logic is unaffected.
Changes
clawteam/team/waiter.py: Addedimport threading, wrappedsignal.signal()/signal.getsignal()calls with a main-thread guard.