VIRTWINKVM-1882: Read VM names from config

[bhbhatt]

1. Hostnames come from platform JSON — not hardcoded "CL" + number, so custom names work.
2. One source of truth — Ruby + Windows + HLK use the same client names from the platform.
3. Works with any client count — 1, 2, 3+ clients via args.ps1 ($VMNAMES length matches platform).
4. Lowercase / uppercase JSON both work — install upcases for Windows; test uses casecmp? for HLK.
5. Aligns with Windows/HLK — hostnames are case-insensitive; AutoHCK no longer fails on cl1 vs CL1.
6. Safer for future platforms — change names in JSON + reinstall; no PowerShell formula to update.

[gemini-code-assist]

Code Review

This pull request introduces dynamic VM naming using a $VMNAMES array across setup scripts and helper engines, replacing hardcoded computer names. Feedback highlights two potential issues: a possible NoMethodError in machine_name_match? if machine_name is nil, and a potential out-of-bounds array access in client.ps1 if $clientNumber exceeds the $VMNAMES array bounds.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

If machine_name is nil, calling casecmp? on it will raise a NoMethodError because NilClass does not implement casecmp?. Previously, machine['name'].eql?(@name) would safely return false if machine['name'] was nil. To prevent potential crashes, we should ensure machine_name is not nil before calling casecmp?.

    def machine_name_match?(machine_name)
      machine_name && machine_name.casecmp?(@name)
    end

[gemini-code-assist]

If $clientNumber is out of bounds of the $VMNAMES array (for example, due to an unexpected MAC address or mismatched configuration), $clientName will be $null. Passing $null to Rename-Computer -NewName will result in an empty string argument error. Adding a check to ensure $clientName is valid before proceeding improves robustness and error reporting.

            $clientName = $VMNAMES[$clientNumber]
            if (-not $clientName) {
                Write-Error "No VM name found in VMNAMES for client number $clientNumber"
            }

[kostyanf14]

will be useful

[kostyanf14]

Is there any reason why in example " is used ("STUDIO", "CL1", "CL2") while there we wrap strings in '?

3.3.7 :001 > list = ["Name1", "Name2", "Name3"]
 => ["Name1", "Name2", "Name3"] 
3.3.7 :002 > list.map { |item| "'#{item.to_s.gsub("'", "''")}'" }.join(', ')
 => "'Name1', 'Name2', 'Name3'" 

[bhbhatt]

sorry by mistake will change this to single case

[kostyanf14]

Just replace .eql? with casecmp?, no need for extra function

[kostyanf14]

same