Implement direct controller and E2E fixtures for LoggingLogExclusion#9713
Open
codebot-robot wants to merge 1 commit into
Open
Implement direct controller and E2E fixtures for LoggingLogExclusion#9713codebot-robot wants to merge 1 commit into
codebot-robot wants to merge 1 commit into
Conversation
justinsb
reviewed
Jun 11, 2026
Comment on lines
+134
to
+148
| func getParentString(id *krm.LoggingLogExclusionIdentity) string { | ||
| if id.Project != "" { | ||
| return fmt.Sprintf("projects/%s", id.Project) | ||
| } | ||
| if id.Folder != "" { | ||
| return fmt.Sprintf("folders/%s", id.Folder) | ||
| } | ||
| if id.Organization != "" { | ||
| return fmt.Sprintf("organizations/%s", id.Organization) | ||
| } | ||
| if id.BillingAccount != "" { | ||
| return fmt.Sprintf("billingAccounts/%s", id.BillingAccount) | ||
| } | ||
| return "" | ||
| } |
Collaborator
There was a problem hiding this comment.
We should move this to ParentString() on LoggingLogExclusionIdentity
justinsb
reviewed
Jun 11, 2026
Comment on lines
+256
to
+268
| var maskedActual *loggingpb.LogExclusion | ||
| { | ||
| // A "trick" to only compare spec fields - round trip via the spec | ||
| mapCtx := &direct.MapContext{} | ||
| spec := LoggingLogExclusionSpec_FromProto(mapCtx, actual) | ||
| if mapCtx.Err() != nil { | ||
| return nil, nil, mapCtx.Err() | ||
| } | ||
| maskedActual = LoggingLogExclusionSpec_ToProto(mapCtx, spec) | ||
| if mapCtx.Err() != nil { | ||
| return nil, nil, mapCtx.Err() | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Use mappers.OnlySpecFields
Also update the skill if this isn't clear
Collaborator
|
Great job - two nits but really good stuff |
Implement the direct controller for LoggingLogExclusion under pkg/controller/direct/logging/. Add LogExclusion mock endpoints under mockgcp/mocklogging/. Enable LoggingLogExclusion in sample E2E test harness. Fixes GoogleCloudPlatform#9710
codebot-robot
force-pushed
the
issue_9710
branch
from
23ce7c0 to
c963fed
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see the commit details for the direct controller and mockgcp Logging LogExclusion API implementations.
Fixes #9710