dns: Move DNSResponsePolicy to identity and refs pattern#9709
Merged
Conversation
This PR migrates DNSResponsePolicy to use the modern `identity.IdentityV2` and `refs.Ref` patterns with support for both primary (location-based) and fallback (location-less) URL templates. Key changes: - Refactored `apis/dns/v1alpha1/dnsresponsepolicy_identity.go` to use both primary and fallback `gcpurls.Template` formats, allowing standard location-less GCP response policy URLs to be parsed successfully. - Updated `apis/dns/v1alpha1/dnsresponsepolicy_identity_test.go` unit tests to assert that without-location format is correctly parsed. - Registered the fallback format as an exception in `pkg/gcpurls/registry_test.go` to maintain CAI registry alignment. - Created transition journal entry in `.gemini/skills/kcc-identity-reference/journal/DNSResponsePolicy.md`. Fixes GoogleCloudPlatform#9707
justinsb
approved these changes
Jun 11, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
via the queue into
GoogleCloudPlatform:master
with commit Jun 11, 2026
2da7cd6
345 of 346 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates
DNSResponsePolicyto use the modernidentity.IdentityV2andrefs.Refpatterns, supporting both primary (location-based) and fallback (location-less) URL templates.Key Changes:
DNSResponsePolicyIdentitywith bothDNSResponsePolicyIdentityFormat(projects/{project}/locations/{location}/responsePolicies/{responsePolicy}) andDNSResponsePolicyIdentityFallbackFormat(projects/{project}/responsePolicies/{responsePolicy}). This allows KCC to successfully parse standard location-less GCP response policy URLs.apis/dns/v1alpha1/dnsresponsepolicy_identity_test.goto assert correct parsing of standard GCP response policy URLs (without location).//dns.googleapis.com/projects/{}/responsePolicies/{}inpkg/gcpurls/registry_test.goto maintain registry alignment tests..gemini/skills/kcc-identity-reference/journal/DNSResponsePolicy.md.Fixes #9707