feat(monitoring): implement direct KRM types and generate.sh for MonitoringAlertPolicy#9692
Open
codebot-robot wants to merge 1 commit into
Open
feat(monitoring): implement direct KRM types and generate.sh for MonitoringAlertPolicy#9692codebot-robot wants to merge 1 commit into
codebot-robot wants to merge 1 commit into
Conversation
…toringAlertPolicy This PR implements direct KRM types and configures generate.sh for MonitoringAlertPolicy, achieving 100% CRD schema compatibility with the baseline. ### Changes: - Enabled MonitoringAlertPolicy generation in apis/monitoring/v1beta1/generate.sh. - Hand-coded alertpolicy_types.go ensuring exact compatibility with the baseline CRD, incorporating custom references without kind fields to trigger automatic oneOf blocks. - Added custom, robust mapping functions in alertpolicy_mappings.go to handle pointer/non-pointer conversions, required fields, and empty string durations. - Created monitoringalertpolicy_fuzzer.go using type-safe helpers and triaged unmapped/unimplemented proto fields, successfully passing 100,000 fuzzing roundtrips. - Regenerated manifests and reports. Fixes GoogleCloudPlatform#9689
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements direct KRM types and configures generate.sh for MonitoringAlertPolicy, achieving 100% CRD schema compatibility with the baseline.
Changes:
Fixes #9689