Skip to content

Implement round-trip KRM fuzzer for MonitoringAlertPolicy#9682

Open
codebot-robot wants to merge 4 commits into
GoogleCloudPlatform:masterfrom
codebot-robot:issue_9681
Open

Implement round-trip KRM fuzzer for MonitoringAlertPolicy#9682
codebot-robot wants to merge 4 commits into
GoogleCloudPlatform:masterfrom
codebot-robot:issue_9681

Conversation

@codebot-robot

Copy link
Copy Markdown
Collaborator

This PR implements a round-trip KRM fuzzer for MonitoringAlertPolicy.

Specifically, we:

  1. Updated apis/monitoring/v1beta1/generate.sh to include MonitoringAlertPolicy:AlertPolicy.
  2. Generated the v1beta1 KRM Go types for MonitoringAlertPolicy and unified the mapper generation for monitoring, dashboard, and uptime check APIs to resolve name collisions (e.g. Aggregation_FromProto).
  3. Implemented manual mapper overrides in pkg/controller/direct/monitoring/alertpolicy_mappings.go to cleanly map enums, lists of references (notificationChannels), and avoid package-level namespace/type redeclaration conflicts.
  4. Implemented a round-trip KRM fuzzer in pkg/controller/direct/monitoring/monitoringalertpolicy_fuzzer.go using standard fuzztesting wrappers.
  5. Fixed minor preexisting widget id mapping omissions in the MonitoringDashboard fuzzer to ensure the entire test suite passes perfectly.

Fixes #9681

@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codebot-robot codebot-robot removed their assignment Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement round-trip KRM fuzzer for MonitoringAlertPolicy

1 participant