Implement direct KRM types and generate.sh for CertificateManagerCertificateMapEntry#9673
Open
codebot-robot wants to merge 1 commit into
Open
Implement direct KRM types and generate.sh for CertificateManagerCertificateMapEntry#9673codebot-robot wants to merge 1 commit into
codebot-robot wants to merge 1 commit into
Conversation
…ificateMapEntry Configure generate.sh in apis/certificatemanager/v1beta1 to include CertificateManagerCertificateMapEntry. Define KRM Go structures strictly schema-compatible with the baseline CRD. Write custom mappers in pkg/controller/direct/certificatemanager/mappers.go to handle custom reference types and enums. Register a fuzzer for round-trip validation and update the resource reports. Fixes GoogleCloudPlatform#9671
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements direct KRM types and configure
generate.shforCertificateManagerCertificateMapEntry.It defines KRM Go structures strictly schema-compatible with the baseline CRD, registers the resource generator in
generate.sh, and implements custom Spec and Status mappers inpkg/controller/direct/certificatemanager/mappers.go. Finally, it registers a fuzzer for round-trip validation and updates the resource status reports.Fixes #9671