Implement identity and reference types for ComputeNetworkAttachment#9630
Open
codebot-robot wants to merge 1 commit into
Open
Implement identity and reference types for ComputeNetworkAttachment#9630codebot-robot wants to merge 1 commit into
codebot-robot wants to merge 1 commit into
Conversation
Collaborator
|
Please rebase to pick up fixes to tests-e2e-fixtures-billingbudgets on head |
auto-merge was automatically disabled
June 10, 2026 11:43
Head branch was pushed to by a user without write access
codebot-robot
force-pushed
the
issue_9627
branch
from
3e67e6a to
895a10d
Compare
codebot-robot
force-pushed
the
issue_9627
branch
from
895a10d to
b8ac732
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Collaborator
|
Please rebase |
codebot-robot
force-pushed
the
issue_9627
branch
from
b8ac732 to
8b1f814
Compare
justinsb
previously approved these changes
Jun 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Collaborator
|
One more rebase, I'm afraid |
This commit implements the identity and reference types for ComputeNetworkAttachment following the standard IdentityV2 and refs.Ref pattern. Key Changes: - Implement identity.IdentityV2 and identity.Resource interfaces for ComputeNetworkAttachment in networkattachment_identity.go. - Implement refs.Ref interface for ComputeNetworkAttachmentRef in networkattachment_reference.go. - Update networkattachment_controller.go to use the new identity and reference structure. - Add comprehensive unit tests in networkattachment_identity_test.go. Fixes GoogleCloudPlatform#9627
codebot-robot
force-pushed
the
issue_9627
branch
from
8b1f814 to
6e9281c
Compare
justinsb
approved these changes
Jun 11, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the identity and reference types for
ComputeNetworkAttachmentfollowing the canonicalIdentityV2andrefs.Refpattern.Key Changes:
identity.IdentityV2andidentity.Resourceinterfaces forComputeNetworkAttachmentusinggcpurls.Templateinapis/compute/v1alpha1/networkattachment_identity.go.refs.Refinterface forComputeNetworkAttachmentRefinapis/compute/v1alpha1/networkattachment_reference.go.pkg/controller/direct/compute/networkattachment_controller.goto use the new modern identity and reference structure.apis/compute/v1alpha1/networkattachment_identity_test.goverifying identity parsing, validation, and reference normalization.Fixes #9627