feat(checks): parallel-safe eval checkpoint and resume - #2660
Open
davidberenstein1957 wants to merge 4 commits into
Open
feat(checks): parallel-safe eval checkpoint and resume#2660davidberenstein1957 wants to merge 4 commits into
davidberenstein1957 wants to merge 4 commits into
Conversation
Persist suite generate/run progress under fingerprint-keyed JSONL stores so interrupted evals can resume by default without redoing completed work.
Disable default checkpointing in test conftest, keep GISKARD_CHECKPOINT=0 from blocking explicit dirs, and exclude callable targets when dumping generated scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mid-run eval checkpoints so a killed
Suite.runorgenerate_suitecan pick up where it left off. Storage is an append-only JSONLRunStore(manifest.json+events.jsonl), safe under parallel scenario/generator workers.By default, runs write under
.giskard/checkpoints/<fingerprint_hash>/and resume when that fingerprint already exists. Change the suite identity (or generation knobs) and you get a new hash / fresh store. Closes #2657.Usage
Default (auto checkpoint + resume)
Same for scan entrypoints — kwargs pass through:
Explicit root, or turn off
Env knobs
GISKARD_CHECKPOINT=0checkpoint_dir=...still works.GISKARD_CHECKPOINT_DIR.giskard/checkpoints).GISKARD_CHECKPOINT_RESUME0/false→ no resume;force→ force mode; otherwise resume on.# CI / one-off: no shared .giskard resume pollution GISKARD_CHECKPOINT=0 pytest ...Generation
Behavior notes
Suite.run) or finished generator (generate_suite). Not step/item-level yet; schema is meant to grow.checkpoint_ids; generate phase keys on description, languages, generators, seed, target mode,max_scenarios. Tags/steps are not in the hash yet — rearranging scenarios that keep the same ids can still resume..giskard/is gitignored — keep checkpoints local.conftest.pysetGISKARD_CHECKPOINT=0so unit tests do not share or resume the default tree.exclude={"target"}so callables do not break JSON.Test plan
RunStore(append, concurrent writers, fingerprint mismatch / force)Suite.runcheckpoint + default resume (serial/parallel order preserved)generate_suitegenerator-level resumesafe for buildlabel if you want those secrets-backed checks too