feat(checks): add built-in retrieval quality checks - #2654
Open
davidberenstein1957 wants to merge 19 commits into
Open
feat(checks): add built-in retrieval quality checks#2654davidberenstein1957 wants to merge 19 commits into
davidberenstein1957 wants to merge 19 commits into
Conversation
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ity-checks # Conflicts: # libs/giskard-checks/src/giskard/checks/__init__.py # libs/giskard-checks/src/giskard/checks/builtin/__init__.py
…nto feat/retrieval-quality-checks
CI installs latest ruff via uv tool install, which formats Python fenced blocks in Markdown. Align docs with that so make check passes.
# Conflicts: # README.md
Merging main's README rewrite into the ruff-format branch produced a triple blank line before get_answer(); ruff format wants two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Formatted follow-up of #2451 (@harsh21234i).
Same change as #2451, plus ruff format/lint fixes so CI
make checkcan get past format/import sorting.Why
#2451 was blocked on CI lint (typically
check-formaton README markdown fences; for some PRs alsoruff checkimport sorting).Supersedes
Please close #2451 in favor of this PR once CI is green.
Test plan