ci: auto-format and commit on same-repo PRs - #2641
Open
davidberenstein1957 wants to merge 8 commits into
Open
Conversation
Fork PRs and main keep check-only; same-repo PRs run make format and push a style commit when needed so contributors are not blocked on ruff.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Inline the contents:write rationale, keep persist-credentials false on checkout, and inject the token only for push (same pattern as release.yml). Also stage only *.py so format commits stay limited to ruff output.
GITHUB_TOKEN pushes leave the new pull_request run in action_required and never auto-execute, so skipping check/tests after a format push left a hollow green lint job. Match release.yml: commit locally, always run make check on the formatted tree, then push with the Release App token. Co-authored-by: Kevin Messiaen <kevinmessiaen@users.noreply.github.com>
4 tasks
Limit create-github-app-token to this repository and contents:write so the format push does not inherit blanket installation permissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make formatand, if anything changed, commitsstyle: auto-formatand pushes to the PR branch.main, andworkflow_dispatchstay check-only (make check) with no auto-commit.Test plan
style: auto-formatcommit, then a follow-up run passesmake check.make checkruns as today.contents: writeon lint.