-
-
Notifications
You must be signed in to change notification settings - Fork 478
[WIP] feat: [ENG-1568] add to_hub_format() in SuiteResult
#2560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
henchaves
wants to merge
7
commits into
main
Choose a base branch
from
feature/eng-1568-snapshot-import-upload-suiteresult-to-the-hub-as-a-local
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d02f73b
add SuiteResult.to_hub_format and TestCaseResult.trace_index
henchaves 4a326d5
Merge branch 'main' into feature/eng-1568-snapshot-import-upload-suit…
henchaves fbb094e
add details to skipped checks
henchaves 39b93db
fix serialization
henchaves ee73216
fallback hub format to str
henchaves 6782dd0
handle skipped steps by setting trace index appropriately
henchaves 8b215a7
Merge branch 'main' into feature/eng-1568-snapshot-import-upload-suit…
henchaves File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| from .hub import to_hub_format | ||
| from .junit import to_junit_xml | ||
|
|
||
| __all__ = ["to_junit_xml"] | ||
| __all__ = ["to_hub_format", "to_junit_xml"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| """Hub format export for SuiteResult.""" | ||
|
|
||
| from typing import Any | ||
|
|
||
| from ..core.result import SuiteResult | ||
|
|
||
|
|
||
| def to_hub_format(result: SuiteResult) -> dict[str, Any]: | ||
| """Convert a SuiteResult into a JSON-serializable Giskard Hub payload. | ||
|
|
||
| The returned dict is the payload accepted by the Giskard Hub API and the Giskard Hub Python SDK. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| result : SuiteResult | ||
| The suite result to convert. | ||
|
|
||
| Returns | ||
| ------- | ||
| dict[str, Any] | ||
| JSON-serializable representation of the suite result | ||
| """ | ||
| return result.model_dump(mode="json", fallback=str) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a step does not add any interactions (i.e.,
step.interactsis empty), but previous steps have already added interactions to the trace,trace.interactionswill not be empty. In this case,trace_indexwill incorrectly be set to the index of the last interaction from the previous step instead ofNone.To fix this, we should compare the number of interactions before and after applying the step's interactions.