fix: formalize cross-lib public contracts#2536
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors imports across the giskard-agents, giskard-checks, and giskard-scan packages to ensure that upstream dependencies are imported strictly from their package roots rather than internal submodules. It also introduces automated tests (test_public_import_surface.py) to enforce this import structure. The feedback recommends explicitly specifying encoding="utf-8" when calling path.read_text() in these new test files to prevent potential UnicodeDecodeError issues on systems with different default encodings, such as Windows.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
7334698 to
f562236
Compare
Description
__all__Type of Change
Checklist
CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.