Skip to content

fix: formalize cross-lib public contracts#2536

Open
kevinmessiaen wants to merge 3 commits into
mainfrom
chore/formalize-cross-libs-public-contracts
Open

fix: formalize cross-lib public contracts#2536
kevinmessiaen wants to merge 3 commits into
mainfrom
chore/formalize-cross-libs-public-contracts

Conversation

@kevinmessiaen

@kevinmessiaen kevinmessiaen commented Jun 11, 2026

Copy link
Copy Markdown
Member

Description

  • Added missing public exports to __all__
  • Updated upstream lib to import from main entry point
  • Added regression tests

Type of Change

  • 🥂 Improvement (non-breaking change which improves an existing feature)

Checklist

@kevinmessiaen kevinmessiaen self-assigned this Jun 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors imports across the giskard-agents, giskard-checks, and giskard-scan packages to ensure that upstream dependencies are imported strictly from their package roots rather than internal submodules. It also introduces automated tests (test_public_import_surface.py) to enforce this import structure. The feedback recommends explicitly specifying encoding="utf-8" when calling path.read_text() in these new test files to prevent potential UnicodeDecodeError issues on systems with different default encodings, such as Windows.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread libs/giskard-checks/tests/test_public_import_surface.py Outdated
Comment thread libs/giskard-scan/tests/test_public_import_surface.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants