Skip to content

chore: add optional deps to giskard-scan#2530

Open
henchaves wants to merge 2 commits into
mainfrom
chore/add-scan-optional-deps
Open

chore: add optional deps to giskard-scan#2530
henchaves wants to merge 2 commits into
mainfrom
chore/add-scan-optional-deps

Conversation

@henchaves

@henchaves henchaves commented Jun 9, 2026

Copy link
Copy Markdown
Member

Description

This PR makes it possible to install giskard-scan along with giskard-agents[provider].

Example:

pip install "giskard-scan[openai]"
pip install "giskard-scan[litellm]"
pip install "giskard-scan[all]"

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@henchaves henchaves requested a review from kevinmessiaen June 9, 2026 08:21
@henchaves henchaves added the Lockfile Temporary label to update pdm.lock label Jun 9, 2026
@henchaves henchaves self-assigned this Jun 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces optional dependencies to the giskard-scan package in pyproject.toml (specifically for openai, google, anthropic, litellm, and all), mapping them to corresponding extras in giskard-agents. The uv.lock file has been updated accordingly to reflect these changes. There are no review comments, and the changes look correct and well-structured.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Lockfile Temporary label to update pdm.lock Scope: Scan

Development

Successfully merging this pull request may close these issues.

1 participant