fix(checks): improve suite failure check info#2529
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the extraction and formatting of check parameters to display them in console reports and failure messages. It also refactors check label retrieval by adding a check_label property to CheckResult. The review feedback correctly identifies potential AttributeError risks where details are accessed via .get() without first verifying that the object is a dictionary, and provides defensive coding suggestions to prevent runtime crashes.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Addressed the review comments by making
Checks run:
|
kevinmessiaen
left a comment
There was a problem hiding this comment.
To me this seems not robust. We should probably make the check name a direct property of CheckResult instead of having to guess where it's inside the details
|
going through changes ... |
|
Addressed your's feedback by making
Also stabilized the suite parallel timing test so it compares parallel vs serial execution directly. Checks:
|
|
any update @kevinmessiaen ? |
Closes #2521
Summary
Testing
.venv\Scripts\python.exe -m pytest -q libs/giskard-checks/tests/scenarios/test_testcase.py libs/giskard-checks/ tests/export/test_junit.pyuv run --no-sync ruff check libs/giskard-checks/src/giskard/checks/core/result.py libs/giskard-checks/src/giskard/ checks/testing/runner.py libs/giskard-checks/src/giskard/checks/export/junit.py libs/giskard-checks/tests/scenarios/ test_testcase.py libs/giskard-checks/tests/export/test_junit.py