feat(checks): add consensus retries for LLM-based checks#2483
Open
harsh21234i wants to merge 2 commits into
Open
feat(checks): add consensus retries for LLM-based checks#2483harsh21234i wants to merge 2 commits into
harsh21234i wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces multi-run support for LLM-based checks, allowing users to specify a number of runs and a consensus strategy (majority, unanimous, or any) to determine the final result. The implementation includes logic for aggregating results and selecting representative outputs for the final report. The review feedback suggests a performance optimization to execute the multiple LLM runs in parallel using asyncio.gather instead of the current sequential execution.
Contributor
Author
|
hey @kevinmessiaen can you look into this?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2372
Summary
num_runsandconsensustoBaseLLMCheckmajority,unanimous, andanyconsensus strategiesdetails["runs"]when multiple runs are usedTesting
uv run -m pytest -q libs/giskard-checks/tests/builtin/test_base.py libs/giskard-checks/tests/builtin/test_judge.py libs/giskard-checks/tests/builtin/ test_groundedness.py libs/giskard-checks/tests/builtin/test_conformity.pyuv run -m pytest -q libs/giskard-checks/tests/builtinuv run ruff check libs/giskard-checks/src/giskard/checks/judges/base.py libs/giskard-checks/tests/builtin/test_base.py