DRAFT: Bloodhound Integration#655
Closed
chrismaddalena wants to merge 54 commits into
Closed
Conversation
… configured and wire up pulling bhe finding data into the report serializer context
…ound into the report data serializer as a method field
Have to edit the old migration to fix the defaults.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #655 +/- ##
==========================================
- Coverage 92.38% 91.53% -0.86%
==========================================
Files 342 353 +11
Lines 19771 20101 +330
==========================================
+ Hits 18266 18400 +134
- Misses 1505 1701 +196 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ColonelThirtyTwo
force-pushed
the
bloodhound-integration
branch
from
fb73023 to
b0ae702
Compare
The endpoint is available on both the admin page and the project page.
It wasn't passing down arguments to the base
Can now just assign a variable either a Project or the global config and access fields duck-typedly.
Display the raw data available to templates. Filtering may come later.
Exact columns TBD
Shows the Test/Fetch BloodHound buttons on the BloodHound tab always. Refactors the views a bit to deduplicate some logic as well.
Remove BloodHound data from admin panel since it won't have bootstrap.
Since it has more than findings
The settings overrides MESSAGE_TAGS to work with bootstrap but not with the admin panel. Work around this by manually passing the "error" class to the message.
Rather than passing a ton of formatting arguments to the init of the report writer and converters, just pass in the ReportTemplate object and get the formatting properties from that.
BloodHound assets use H1/H2 headings, which isn't what's wanted when embedding them into a report. This patch adds a setting to the ReportTemplate to increase the heading's level by a configurable amount (ex. heading 1 with offset 2 becomes heading 3).
Collaborator
Author
|
Closing this in favor of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR for the BloodHound integration work.