Foundational work for non-referenced distributions#4745
Open
dafeder wants to merge 16 commits into
Open
Conversation
This reverts commit 78a79bf.
5 tasks
dafeder
changed the title
dafeder
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4734
This PR sets up a new series of contracts and a basic resource discovery service for getting resources directly from the Dataset object. This also includes a new set of "Dispatch" classes in the datastore that will be called by the resource discovery system.
Full transparency: while I coded this PR manually (except for some light autocomplete help), it was based on a spec and task list built with speckit and copilot.
I'm not sure I would have done the whole dispatch piece on my own on the first pass, as it strikes me as a bit redundant with existing pieces of the datastore. It's possible it could be ripped out later to let resource discovery simply call datastore import directly. OTOH it is a more comprehensible flow than what we have now so we'll see.UPDATE: removed dispatcher