#4622 Add validation killswitch#4658
Draft
swirtSJW wants to merge 3 commits into
Draft
Conversation
swirtSJW
force-pushed
the
4622-add-validation-killswitch
branch
2 times, most recently
from
4dc1e10 to
7ebccdb
Compare
swirtSJW
force-pushed
the
4622-add-validation-killswitch
branch
from
7ebccdb to
cfd8db7
Compare
swirtSJW
commented
Feb 16, 2026
| * @param object|mixed $items | ||
| * Items to validate. | ||
| */ | ||
| protected function validateItems($items): void { |
Contributor
Author
There was a problem hiding this comment.
I did not really want to break this out into a separate function, but Qlty had opinions. Adding the one if wrapper brought it up to 6 layers deep.
Contributor
Author
|
@dafeder raised in Slack that he has concerns about this disabling all validation and suggests that it be scoped to only disabling data read/load, not data write. I think that sounds reasonable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4622
Describe your changes
QA Steps
Checklist before requesting review
If any of these are left unchecked, please provide an explanation