Skip to content

#4655 Add link to node/123 to dataset import status table.#4656

Open
swirtSJW wants to merge 5 commits into
2.xfrom
4655-add-node-link-to-import-status
Open

#4655 Add link to node/123 to dataset import status table.#4656
swirtSJW wants to merge 5 commits into
2.xfrom
4655-add-node-link-to-import-status

Conversation

@swirtSJW

@swirtSJW swirtSJW commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

Fixes #4655

Describe your changes

QA Steps

  • git checkout 4655-add-node-link-to-import-status
  • drush cr to pick up twig changes
  • visit /dashboard/datastore
  • validate that the dataset identifier comes after/below the title
  • validate that the dataset title has no link
  • validate the "view" links to the FE version of the dataset page
  • validate the "admin" links to the node version of the dataset page
  • inspect the source and validate that the "admin" link has an aria-label that reads "admin: "
  • inspect the source and validate that the "view" link has an aria-label that reads "view: "

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

@swirtSJW swirtSJW force-pushed the 4655-add-node-link-to-import-status branch from 6ddedbf to 8949d30 Compare February 13, 2026 14:06
@swirtSJW swirtSJW marked this pull request as draft February 13, 2026 14:24
@swirtSJW swirtSJW force-pushed the 4655-add-node-link-to-import-status branch 2 times, most recently from 4b5cc57 to 9225ea9 Compare February 13, 2026 18:12
@swirtSJW swirtSJW marked this pull request as ready for review February 13, 2026 18:25
Comment thread modules/datastore/tests/src/Unit/Form/DashboardFormTest.php Outdated
@swirtSJW swirtSJW force-pushed the 4655-add-node-link-to-import-status branch from 9225ea9 to 5104f28 Compare February 13, 2026 18:30
@swirtSJW swirtSJW self-assigned this Feb 14, 2026
@swirtSJW swirtSJW requested a review from dafeder February 15, 2026 02:33

@dafeder dafeder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself is fine, but I'm not sure why you added the node_id to the data in all the tests but then never have assertions for it?

@swirtSJW

Copy link
Copy Markdown
Contributor Author

Code itself is fine, but I'm not sure why you added the node_id to the data in all the tests but then never have assertions for it?

I had to add the node_id to the tests because otherwise the template errors out if the node_id does not exist in the clall to path().

I can add additional assertions to make sure that the twig path() works, but that seems excessive to test that a core twig function does its job. That is all it would test since it blows up if you feed it something that is not a node id.

@dafeder dafeder added the 4.x label Feb 18, 2026

@dafeder dafeder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but holding off on merging until 4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add node link to Datastore Import-Status Dashboard

2 participants