#4655 Add link to node/123 to dataset import status table.#4656
#4655 Add link to node/123 to dataset import status table.#4656swirtSJW wants to merge 5 commits into
Conversation
6ddedbf to
8949d30
Compare
4b5cc57 to
9225ea9
Compare
9225ea9 to
5104f28
Compare
dafeder
left a comment
There was a problem hiding this comment.
Code itself is fine, but I'm not sure why you added the node_id to the data in all the tests but then never have assertions for it?
I had to add the node_id to the tests because otherwise the template errors out if the node_id does not exist in the clall to path(). I can add additional assertions to make sure that the twig path() works, but that seems excessive to test that a core twig function does its job. That is all it would test since it blows up if you feed it something that is not a node id. |
dafeder
left a comment
There was a problem hiding this comment.
Approved, but holding off on merging until 4.x
Fixes #4655
Describe your changes
QA Steps
Checklist before requesting review
If any of these are left unchecked, please provide an explanation