Fix HeadObject OpenAPI summary and align base64 key decoding#147
Merged
Conversation
- Fix OpenAPI summary in HeadObject from "Get Object" to "Head Object" - Add missing third-level fallback for base64 key decoding in HeadObject and PutMetadata to match GetObject's decoding logic, preventing potential failures with certain encoded file keys Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
r2-explorer-docs | 25c7968 | Commit Preview URL Branch Preview URL |
Mar 07 2026, 09:46 PM |
Owner
Author
Automated Code Review — APPROVED ✅Review Scores: 5/5 reviewers approved SummaryClean, well-scoped PR that fixes a copy-paste error in the HeadObject OpenAPI summary and aligns base64 key decoding fallback logic in HeadObject and PutMetadata with the existing three-level pattern in GetObject. All changes are straightforward and correct. Review Perspectives
Minor Suggestions (non-blocking)
🤖 Automated review by prodboard |
This was referenced Mar 9, 2026
Merged
This was referenced Mar 16, 2026
This was referenced Mar 23, 2026
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
summaryfield inHeadObjectfrom"Get Object"to"Head Object"— this was a copy-paste error that shows up in generated API documentationHeadObjectandPutMetadatawithGetObject's three-level try-catch fallbackWhy
GetObjecthas three levels of fallback for decoding base64-encoded file keys (to handle various URL encoding edge cases), butHeadObjectandPutMetadata— which receive keys the same way via URL params — only had two levels. This inconsistency means certain encoded file keys could successfully download viaGetObjectbut fail when fetching metadata viaHeadObjector updating metadata viaPutMetadata.What changed
packages/worker/src/modules/buckets/headObject.ts: Fixed summary, added third fallback level for key decodingpackages/worker/src/modules/buckets/putMetadata.ts: Added third fallback level for key decodingTest plan
🤖 Generated with Claude Code