Skip to content

Fix Content-Disposition header injection in GetObject #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
G4brym merged 3 commits into from
Mar 9, 2026
Merged

Fix Content-Disposition header injection in GetObject #145

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
132583f
Fix Content-Disposition header injection in GetObject
G4brym Mar 7, 2026
c5d02aa
Merge branch 'main' into fix/content-disposition-header-injection
G4brym Mar 9, 2026
e691672
Fix CI: update test for new Content-Disposition format and add changeset
G4brym Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/worker/src/modules/buckets/getObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,14 @@ export class GetObject extends OpenAPIRoute {
object.writeHttpMetadata(headers);
headers.set("etag", object.httpEtag);
headers.set("content-length", object.size.toString());

const fileName = filePath.split("/").pop() || "download";
const asciiFileName = fileName
.replace(/[^\x20-\x7E]/g, "_")
.replace(/"/g, "'");
headers.set(
"Content-Disposition",
`attachment; filename="${filePath.split("/").pop()}"`,
`attachment; filename="${asciiFileName}"; filename*=UTF-8''${encodeURIComponent(fileName)}`,
);

return new Response(object.body, {
Expand Down
Loading