Msgs#4
Open
yar-malik wants to merge 12 commits into
Open
Conversation
added 12 commits
August 22, 2013 14:34
…ndentation of the code
Navigation.msg: changing name of variables AntennaParameter.msg: Better identation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Almost all the message files for the components of rtklib have been written here. I have not implemented time which is instance of a struct gtime_t in my main_aisehe.cpp file. After doing romake, I get an error which I believe deal mostly with the file rtcm.cpp. In previous version of rtklib without patches there was only one rtcm file but in the latest version of rtklib they divided the rtcm file into 2-3 files namely rtcm2 and rtcm3 and added more functionality to it. After searching for the error I think it deals with issues with extern, static and making local functions inside another function.
Another thing is that I did not implement navigmsg.lexion.coef which should be implemented.
Also some components of pcv_t (satellite antenna line 164 main_aisehe.cpp file) are missing like navigmsg.pcvs[i].* .
All of sbssat(SBAS satellite corrections type) is implemented. The comment with it is misleading
Mostly the letters I have used like a,b,c ....,o are just used as ints to iterate for for() Loops.
There are 3 functions (obsfunc, navmsgfunc, raw2ros) which are called inside main. In ROS one can make and destroy as many nodehandlers as possible((so can call them in functions) but one cannot do the same with publishers. Publishers should be made once and should not be destroyed(care taken to avoid putting them in a loops).