Skip manual scaler scans with TTL cleanup#160
Open
tclinkenbeard-oai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
USE_K8S_TTL_CONTROLLER=trueWhy
With roughly 8k Joshua agent objects, the scaler spent more than 10 minutes in
kubectl get jobs -o jsonbefore its first queue check even though TTL cleanup was enabled. The TTL path already relies on finished-job TTLs, so these scans are redundant.Validation
bash -n k8s/agent-scaler/agent-scaler.shshellcheck -S warning k8s/agent-scaler/agent-scaler.shgit diff --check