Shard Joshua test admission for large ensembles#159
Open
tclinkenbeard-oai wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claim_shard_countWhy
try_starting_test()currently reads the aggregatestartedcounterserializably and then atomically increments that same key. Thousands of agents
claiming together conflict on one key, retry as a herd, and can time out before
doing useful work.
With
--property claim_shard_count=10000, each claim reads and increments oneshard whose quota is an exact slice of
max_runs; the aggregatestartedcounter remains an atomic status counter. The shard quotas sum to
max_runs,so the existing
started <= max_runsinvariant is preserved.The protocol is opt-in so operators can drain old agents before enabling it for
new ensembles; legacy agents do not write shard claims.
Validation
python3 -m py_compile joshua/joshua_model.py test_joshua_model.pypytest -q test_joshua_model.py -k 'concurrent_claims_preserve_max_runs or dead_claim_releases_shard or legacy_claims_keep_exact_max_runs'The focused tests ran against a temporary FoundationDB 7.1.57 arm64 package and
passed:
3 passed, 15 deselected.