Add linting and static checks#157
Open
johscheuer wants to merge 3 commits into
Open
Conversation
Contributor
|
For what it's worth, my 2c, I prefer just using "flake8" (which is just "pyflakes" + "pycodestyle" + config/ignore support), because black and pylint cause so much churn on so much unnecessary stuff. But anyway, I recommend changing the max-line-length to 100 or 120 chars, from default 80. That will reduce some of this churn due to "annoying folding". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll enable pylint in another PR as this would require some more changes to the Python code. All code changes are coming from black.