fix(button): center SVG icons in flex layout - #135
Merged
Conversation
SVG icons from @lucide/svelte now display with proper vertical centering in buttons by applying flex layout to SVG elements. Fixes misaligned icons in buttons with inline content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix vertical centering of SVG icons in buttons by setting
display: blockon SVG elements within buttons.Why
SVG elements rendered as inline or inline-flex don't participate correctly in the parent button's flexbox vertical centering (align-items: center). Setting
display: blockallows SVG elements to respect the parent's centering alignment.Test plan
/playgroundconfirms icons are perfectly centered