Skip to content

ci(E2E): Collapse previous Playwright result entries in the sticky PR comment#8012

Merged
khvn26 merged 2 commits into
mainfrom
ci/collapse-e2e-comment-history
Jul 20, 2026
Merged

ci(E2E): Collapse previous Playwright result entries in the sticky PR comment#8012
khvn26 merged 2 commits into
mainfrom
ci/collapse-e2e-comment-history

Conversation

@khvn26

@khvn26 khvn26 commented Jul 15, 2026

Copy link
Copy Markdown
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

I got tired of scrolling through Playwright comments for long-living PRs.

Instead of appending a new entry per run, the comment step now rewrites the single sticky comment on each job: the newest result stays expanded at the top, and every earlier result is folded into one collapsed "Previous results" block. The comment height stays constant no matter how many times E2E runs. History is capped so the body stays under GitHub's comment size limit.

With the four parallel matrix jobs, the last job to finish is the expanded one; the rest sit collapsed in the history block.

How did you test this code?

This is a CI change.

@khvn26
khvn26 requested a review from a team as a code owner July 15, 2026 10:18
@khvn26
khvn26 requested review from talissoncosta and removed request for a team July 15, 2026 10:18
@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Jul 20, 2026 10:38am
flagsmith-frontend-preview Ignored Ignored Preview Jul 20, 2026 10:38am
flagsmith-frontend-staging Ignored Ignored Preview Jul 20, 2026 10:38am

Request Review

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The reusable Docker E2E workflow replaces the sticky comment action with actions/github-script@v7. It updates a marked pull request comment with the latest Playwright success or failure result in an open HTML <details> block and preserves up to 12 earlier results in a collapsed section. The result summary inputs remain unchanged.

Estimated code review effort: 3 (Moderate) | ~20 minutes


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the ci-cd Build, test and deployment related label Jul 15, 2026
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-8012 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-8012 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-8012 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-8012 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-8012 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8012 Finished ✅ Results

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.64%. Comparing base (0cb114b) to head (f241c17).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #8012    +/-   ##
========================================
  Coverage   98.64%   98.64%            
========================================
  Files        1497     1506     +9     
  Lines       59287    59573   +286     
========================================
+ Hits        58481    58767   +286     
  Misses        806      806            

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor
✅ Playwright Test Results (oss - depot-ubuntu-latest-16) — run #18278 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  34 seconds
commit  327c22f
info  🔄 Run: #18278 (attempt 1)

✅ Playwright Test Results (oss - depot-ubuntu-latest-arm-16) — run #18278 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  44 seconds
commit  327c22f
info  🔄 Run: #18278 (attempt 1)

✅ Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16) — run #18278 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 2 suites
duration  11.6 seconds
commit  327c22f
info  🔄 Run: #18278 (attempt 1)

✅ Playwright Test Results (private-cloud - depot-ubuntu-latest-16) — run #18278 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  53.6 seconds
commit  327c22f
info  🔄 Run: #18278 (attempt 1)

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

Zaimwa9
Zaimwa9 previously approved these changes Jul 15, 2026
Rewrite the sticky comment on each job instead of appending: the newest
result stays expanded on top and every earlier result is folded into a
single collapsed "Previous results" block, so the comment height stays
constant across runs. History is capped to keep the body under GitHub's
comment size limit.

beep boop
@github-actions github-actions Bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jul 20, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 55620461-22eb-40cb-9d9b-5c422c7cfd0b

📥 Commits

Reviewing files that changed from the base of the PR and between 327c22f and f241c17.

📒 Files selected for processing (1)
  • .github/workflows/.reusable-docker-e2e-tests.yml

Comment thread .github/workflows/.reusable-docker-e2e-tests.yml
Comment thread .github/workflows/.reusable-docker-e2e-tests.yml
@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #18505 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  1 minute, 1 second
commit  f241c17
info  🔄 Run: #18505 (attempt 1)

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-16 — run #18505 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 4 suites
duration  46 seconds
commit  f241c17
info  🔄 Run: #18505 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #18505 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  45.9 seconds
commit  f241c17
info  🔄 Run: #18505 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #18505 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  37.5 seconds
commit  f241c17
info  🔄 Run: #18505 (attempt 1)

@khvn26
khvn26 merged commit 0838195 into main Jul 20, 2026
36 checks passed
@khvn26
khvn26 deleted the ci/collapse-e2e-comment-history branch July 20, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd Build, test and deployment related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants