Feat 3d terrain buildings by Momototoro · Pull Request #290 · FixMyBerlin/tilda-geo

Momototoro · 2026-06-08T10:02:30Z

Hier Nummer 2

https://github.com/FixMyBerlin/private-issues/issues/3303

PR Review: `feat-3d-terrain-buildings`

Branch Summary

Base Branch: develop
Commits: 4
Core Changes: This PR adds 3D terrain and buildings to the map viewport, and introduces a client-side elevation profile (Höhenprofil) inside the sidebar inspector.

Changed Files (6 total)

File	Status	Description
`RegionMap.tsx`	`Modified`	Enbles 3D terrain (MapTiler DEM), 3D buildings (`fill-extrusion`), drag-rotate, and the compass UI.
`InspectorFeatureElevationProfile.tsx`	`New`	Implements client-side Mapterhorn DEM tile sampling with bilinear interpolation, SVG chart rendering, and hover tooltip.
`InspectorFeatureTilda.tsx`	`Modified`	Embeds the new elevation profile component inside a `<Disclosure title="Höhenprofil">` for `LineString` and `MultiLineString` features.
`byTableName.gen.ts`	`Modified`	Auto-generated topic docs (rebuild).
`inspectorDescriptions.gen.ts`	`Modified`	Auto-generated topic docs (rebuild).
`masterportalByTableName.gen.ts`	`Modified`	Auto-generated topic docs (rebuild).

tordans · 2026-06-09T12:20:19Z

+    // 1. 3D-Gelände (DEM) hinzufügen mit dem vorhandenen MapTiler Key
+    map.addSource('maptiler-terrain', {
+      type: 'raster-dem',
+      url: `https://api.maptiler.com/tiles/terrain-dem/tiles.json?key=ECOoUBmpqklzSCASXxcu`,
+      tileSize: 256,
+    })
+    map.setTerrain({ source: 'maptiler-terrain', exaggeration: 1.5 })
+
+    // 2. 3D-Gebäude aus den Vektorkacheln extrudieren (wird ab Zoom-Stufe 15 sichtbar)
+    map.addLayer({


Verschieben in <Source> <Layer>, siehe https://github.com/FixMyBerlin/fixmyskills/tree/main/skills/react-map-gl

tordans · 2026-06-09T12:21:19Z

@@ -287,7 +316,7 @@ export const RegionMap = () => {

      <Search />

-      <NavigationControl showCompass={false /* TODO: See Story */} visualizePitch={true} />
+      <NavigationControl showCompass={true /* TODO: See Story */} visualizePitch={true} />


Suggested change

<NavigationControl showCompass={true /* TODO: See Story */} visualizePitch={true} />

<NavigationControl showCompass={true} visualizePitch={true} />

Compass: Check…

tordans · 2026-06-09T12:26:37Z

+        {geometry && (geometry.type === 'LineString' || geometry.type === 'MultiLineString') && (
+          <Disclosure title="Höhenprofil">
+            <InspectorFeatureElevationProfile feature={feature} />
+          </Disclosure>
+        )}


Einen Component

Innen: early return guard null (const visible=COND)

tordans · 2026-06-09T12:29:39Z

@@ -270,7 +299,7 @@ export const RegionMap = () => {
      onData={startMapDataLoading}
      onIdle={finishMapDataLoading}
      doubleClickZoom={true}
-      dragRotate={false}
+      dragRotate={true}


UX: Nur conditional an, wenn 3D an?

tordans · 2026-06-09T12:30:31Z

      capacity: 'Geschätzte oder explizit erfasste Anzahl von Stellplätzen.',
+      capacity_source: 'Herkunft der Stellplatzanzahl inklusive Schätz- oder Umverteilungslogik.',
      orientation: 'Ausrichtung der Fahrzeuge im Straßenland zur Verkehrsrichtung.',
      staggered:
        'Besondere Merkmale zur Parkweise, insbesondere bei alternierendem/versetztem Parken auf Fahrbahnen, die zu schmal sind um auf beiden Seiten gleichzeitig zu parken, keine Markierungen und Beschilderungen aufweisen, die das Parken regeln und auf denen gewöhnlich wechselseitig abschnittsweise auf der einen oder anderen Straßenseite geparkt wird oder geparkt werden kann.',


TODO @tordans Reihenfolge muss statisch sein.

tordans · 2026-06-09T12:58:33Z

+    return null
+  }
+
+  if (elevationData.length === 0) {


Was ist denn wenn leer und not loading? => Error case Message

tordans · 2026-06-09T12:59:41Z

+    ) : null
+  }
+
+  // --- SVG Scaling & Math ---


tordans · 2026-06-09T13:00:16Z

+  // Statistics calculation
+  let climb = 0
+  let descent = 0
+  for (let i = 1; i < elevationData.length; i++) {


tordans · 2026-06-09T13:01:04Z

+
+  return (
+    <div className="flex flex-col gap-2.5 rounded-lg border border-gray-200 bg-gray-50/30 p-3">
+      {/* biome-ignore lint/a11y/noStaticElementInteractions: Hover tracking on container */}


nach rebase oxlint

tordans · 2026-06-09T13:01:38Z

+        )}
+      </div>
+
+      {/* Summary Statistics */}


Helper Component

Co-authored-by: Cursor <cursoragent@cursor.com>

Satisfies react-compiler and react-hooks lint rules after oxlint 1.70 upgrade. Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

tordans · 2026-07-06T05:16:15Z

Note to self: https://github.com/visgl/react-map-gl/blob/8.1-release/examples/maplibre/terrain/src/app.tsx https://visgl.github.io/react-map-gl/examples/maplibre/terrain

Momototoro requested a review from tordans June 8, 2026 10:02

tordans requested changes Jun 9, 2026

View reviewed changes

tordans marked this pull request as draft June 23, 2026 09:02

Momototoro force-pushed the feat-3d-terrain-buildings branch 2 times, most recently from 5752ee3 to 4423d4e Compare July 1, 2026 08:13

momo and others added 9 commits July 5, 2026 17:42

feat: add 3D terrain and buildings to map

9d56170

chore: rebuild generated topic docs

edaff78

feat - tile server instead of api

5b0d65b

fix: lint warnings and indentation

84f23aa

fix: update event type in handleLoad function for improved type safety

85dcf1b

chore: rebuild generated topic docs after rebase

7116a5f

Co-authored-by: Cursor <cursoragent@cursor.com>

fix: format after rebase conflict resolution

227f98f

Co-authored-by: Cursor <cursoragent@cursor.com>

fix: derive elevation loading state without setState in effect

b3b65a8

Satisfies react-compiler and react-hooks lint rules after oxlint 1.70 upgrade. Co-authored-by: Cursor <cursoragent@cursor.com>

fix: narrow geometry type before extracting elevation coordinates

d5b6356

Co-authored-by: Cursor <cursoragent@cursor.com>

Momototoro force-pushed the feat-3d-terrain-buildings branch from 4423d4e to d5b6356 Compare July 5, 2026 15:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feat 3d terrain buildings#290

Feat 3d terrain buildings#290
Momototoro wants to merge 9 commits into
FixMyBerlin:developfrom
Momototoro:feat-3d-terrain-buildings

Momototoro commented Jun 8, 2026

Uh oh!

tordans Jun 9, 2026

Uh oh!

tordans Jun 9, 2026

Uh oh!

tordans Jun 9, 2026

Uh oh!

tordans Jun 9, 2026

Uh oh!

tordans Jun 9, 2026

Uh oh!

tordans Jun 9, 2026

Uh oh!

tordans Jun 9, 2026

Uh oh!

tordans Jun 9, 2026

Uh oh!

tordans Jun 9, 2026

Uh oh!

tordans Jun 9, 2026

Uh oh!

tordans Jun 9, 2026

Uh oh!

tordans commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	<NavigationControl showCompass={true /* TODO: See Story */} visualizePitch={true} />
	<NavigationControl showCompass={true} visualizePitch={true} />

Uh oh!

Conversation

Momototoro commented Jun 8, 2026

Hier Nummer 2

PR Review: feat-3d-terrain-buildings

Branch Summary

Changed Files (6 total)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tordans commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

PR Review: `feat-3d-terrain-buildings`