Support for x-id Query Parameter Added by aws-sdk-go-v2 and Other AWS SDKs - #72
Open
desw0lf wants to merge 2 commits into
Open
Support for x-id Query Parameter Added by aws-sdk-go-v2 and Other AWS SDKs#72desw0lf wants to merge 2 commits into
desw0lf wants to merge 2 commits into
Conversation
* add validate-query, implement in deleteObject, deleteObjects, getObject, headObject, putObject (omit listObjects) * remove unused minLength * fix typo: DeleteObject --> DeleteObjects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using the aws-sdk-go-v2 library (and other AWS SDKs), requests to S3 APIs often include an
x-idquery parameter (e.g., x-id=DeleteObjects, x-id=PutObject, x-id=GetObject, etc.).Issue
Current implementation in some handlers (
GetObject,HeadObject,PutObject,DeleteObject,DeleteObjects*) does not account for this parameter and automatically rejects any query parameters present in the URL.Solution
Update the handlers to allow an optional
x-idquery parameter, ensuring compatibility with requests generated by AWS SDKs.Notes
deletequery parameter is still required in theDeleteObjectshandler