Minify XML responses to improve compatibility - #147
Open
jscontrino wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using the MinIO CLI with
filen-s3,putObjectrequests fail. After debugging, I discovered the issue is related to how the MinIO XML parser handles the bucket location returned bygetBucketLocation.Details
filen-s3XML response fromgetBucketLocationcontains newlines.MinIO CLIdoes not trim these newlines when parsing the bucket location."\n \n".Authorizationheader as"\n \n".putObjectrequests fail due to the malformed header.Steps to Reproduce
MinIO CLIto use a filen-s3 instance.mc alias set temporary http://$FILEN_S3_LOCATION $SECRET_ID $SECRET_KEY" --path on --api S3v4putObject.mc cp test temporary/coolify --debug --insecureExpected Behavior
getBucketLocationrepsonse should not contain new lines.Proposed Solution
Turn of pretty printing of XML responses, by setting
prettytofalse. This eliminates newlines.Environment
filen-s3version:0.3.1RELEASE.2025-08-13T08-35-41