feat(battle): custom command card selection

[sheng-28]

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related Issue

• Fixed Better Card/Servant Priority #2139
• Fixed Select a specific card sequence in the command line #2130

Description

• Implemented turn-based custom command card selection
  • Can select up to 3 command cards for each turn
  • Cards defined by CardType and FieldSlot(e.g. B1: Buster of the servant at the front on the field)
  • When all selected cards are available, they would be selected in defined order and card priority-based sort would be skipped
  • Would fall back to card priority sorting when not all selected cards are available
  • When less than 3 cards are selected, more cards would be selected from the rest automatically(e.g. Given user's selection [Q1, A1] and available cards [Q3, B1, A1, B2, Q1], the app would click on [Q1, A1, Q3])
• Added UI on config screen
• Tested on JP server in BlueStacks Air
  • Functions as intended in Daily Quest when using U-Olga's or Ciel's shuffle skill at different waves/turns
  • Works fine with Ishtar in Grand Duel
  • Tested with different Cards Before NP setup
  • Compatible with Order Change (Usually seen in teams that use Ciel + BB summer)
• Might need translations

Screenshots

Entry on Config Screen with preview


Selection interface designed after card priority interface


Servants ordered as their position on battle field, can select one each time

Up to 3 cards can be selected each turn

[github-actions]

Build 959

Download the latest APK for testing here

Note

You need a GitHub account to download the APK.

This URL is valid as long as the artifact has not expired yet.

[ArthurKun21]

Could you also update the wiki with the new entry?

Around here

https://github.com/Fate-Grand-Automata/FGA/blob/master/wiki/scripts/Battle.md#card-priority-optional

[sheng-28]

Added an entry in wiki. Not sure if it's clear enough, let me know if I missed anything.

btw, I didn't notice there's a wiki page until today, would've been a great help for me when I started using the app. I wonder why there isn't an in-app button/link to the wiki page?

[ArthurKun21]

I wonder why there isn't an in-app button/link to the wiki page?

lmao, yea forgot. But personally would love to just have a github pages though

[vybze]

How would this work with #2087 ?

[ArthurKun21]

How would this work with #2087 ?

Personally I think, that is out of scope of this PR when the other PR haven't been merged nor reviewed by reconman yet

[sheng-28]

How would this work with #2087 ?

I didn't know abt the other PR so I only had a quick look. Correct me if I'm wrong.

Based on the implementation of pickCards() in their Card.kt and the one in Card.kt here, (if both were merged successfully) I think the custom selection feature here would have the highest priority when there is a selection setting and those cards are available, otherwise it would fall back to their implementation.

[ArthurKun21]

Let's worry about the other PR once it got reviewed by reconman and merged. The simpler this PR be, the more faster this could get merged.

[danilaml]

Seems useful (and I'd imagine it will get even more useful as more servants with card locking mechanics get added to NA). Is it waiting on review from @reconman (like the other tangentially related MR)?