-
-
Notifications
You must be signed in to change notification settings - Fork 361
feat: Add NP/Star Conditions, Update Target Dialog, and Skill Priority Drag-Sort on Spam Screen #2103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
erectorOps
wants to merge
29
commits into
Fate-Grand-Automata:master
Choose a base branch
from
erectorOps:feature/spam-servant-skill-renovations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Add NP/Star Conditions, Update Target Dialog, and Skill Priority Drag-Sort on Spam Screen #2103
Changes from 22 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
b51fb32
fix: Skill window not closing during cooldown (bugfix)
erectorOps 0a3fb8d
fix: Fix item order bug in DragSortAdapter and remove layout dependen…
erectorOps b2a8637
feat: Optionally render text along with highlights (api-utility)
erectorOps b0e1ea7
feat: Add Hsv data class with extension to convert to Scalar (api-uti…
erectorOps c2c3172
feat: Add HSV-based detection and brightness utilities to Region and …
erectorOps 58289e2
feat: Add API method for bracketed number OCR (api-utility)
erectorOps 4cfee0b
feat: Add function to measure the length of a gauge bar (api-utility)
erectorOps 8d5bc90
feat: Add NP-based usage condition to SpamSkillState (data)
erectorOps bbdd09c
feat: Add star-count-based usage condition to SpamSkillState (data)
erectorOps e2d233f
feat: Replace SpamSkillTarget with AutoSkillAction to support complex…
erectorOps ff6b485
feat: Add priority field and repeat-per-turn option (for Hakuno) to S…
erectorOps 295ee4c
feat: Add utility functions for Skill.Servant to get field slot and s…
erectorOps c5be9be
feat: Ignore skills blocked by Oberon’s Eternal Sleep when using the …
erectorOps 26ffc56
feat: Detect skill cooldown via icon brightness, cast skills by prior…
erectorOps e79f767
feat: add NP charged detection and NP Condition check in SkillSpam (c…
erectorOps f503c79
docs: add detailed testing notes for NP gauge and skill cooldown dete…
erectorOps 4e040fa
feat: feat: implement star count detection and add Star Condition che…
erectorOps e0354d3
feat: Add approximate NP value retrieval and extend NP conditions in …
erectorOps 8d38319
feat: Update SPAM UI resources (colors, dimens, localized, extensions…
erectorOps c932353
feat: Add skill priority item layout for SPAM UI drag-and-drop view (ui)
erectorOps 059bebc
feat: Separate SPAM button label from target screen header to prevent…
erectorOps 08ef296
feat: Update Spam screen Servant skill dialogs and skill priority dra…
erectorOps e9261f6
fix: Return a non-empty slot instead of an empty one for actualSlot
erectorOps a95f88f
fix: Use use to safely release OpenCV Mat rows and columns
erectorOps e9cbce5
fix: Replace full-width spaces with regular ASCII spaces for consistency
erectorOps 1108fb9
fix: Add missing space after when for correct syntax
erectorOps e2faecf
Add isBelowBrightness API to check region brightness directly, avoidi…
erectorOps 72f9d2a
chore(deps): add Reorderable library via Version Catalog
erectorOps e4acbe0
feat: Replace RecyclerView with Reorderable LazyRow for skill priorit…
erectorOps File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OpenCV Mat objects created by
gray.row(y)andgray.col(x)should be released in a try-finally block to ensure proper cleanup even if an exception occurs.