feat: Mighty / Color chain + NP type detection implementation - #2087

Open

Vylantze wants to merge 134 commits into

Fate-Grand-Automata:masterfrom

Vylantze:basic-mighty-chain

Commits on Aug 23, 2025

Add basic Mighty chain implementation
Vylantze
committed
5480ea8
Use the rearranged cards as the baseline
Vylantze
committed
c359a88
Minor refactor to simplify it
Vylantze
committed
fb9e316

Commits on Aug 24, 2025

Fix bug where justRearranged was not calling the correct function (causing a crash because infinite loop). Also fix using cards instead of justRearranged because it does not provide the full 5 cards.
Vylantze
committed
7a8fc72

Commits on Aug 25, 2025

Fix not checking for NP in the first card check. Add unit tests
Vylantze
committed
e88f215

Commits on Aug 28, 2025

Add np matcher test code
Vylantze
committed
553985c
Update images used for checking.
Vylantze
committed
9aa0036
Refactor Mighty Chain logic to different file
Vylantze
committed
44125fb
Add more unit tests
Vylantze
committed
690d56d
Remove unnecessary additions
Vylantze
committed
6826203
Update minimum similarity score to 0.5 (since 0.9 is the matching)
Vylantze
committed
f83166e

Commits on Aug 29, 2025

Refactor: Move ApplyMightyChains to `attack` package
Vylantze
committed
120f774
Test: Update `MightyChainTest` to use `AttackLineUps` and clarify test names
Vylantze
committed
322970c
Test: Extract card lineups for attack tests
Vylantze
committed
9ca62de
Make MightyChainTest use AttackLineUps for all test cases
Vylantze
committed
728252d
Refactor test file location
Vylantze
committed
b69203e
Merge branch 'refactor-mighty' into basic-mighty-chain
Vylantze
committed
e876b05
Add chain priority toggle
Vylantze
committed
e5eaea6
Add rendering for Chain Priority
Vylantze
committed
0f75876
Change Brave Chain text to reflect when it is being used as Chain Priority
Vylantze
committed
29e0f28
Add ChainPrioritySelector
Vylantze
committed
5581ad6
Add chainPriority to functions
Vylantze
committed
d507a52

Commits on Aug 30, 2025

Commits on Aug 31, 2025

Remove MightyChain from BraveChain and add new Attack handling system
Vylantze
committed
02a50c8
Remove WithNPMighty option from BraveChainEnum
Vylantze
committed
9f81a22
Add localization for ChainTypeEnums
Vylantze
committed
0cd8dc1

Commits on Sep 1, 2025

Remove unnecessary imports from Render
Vylantze
committed
22b5952
Refactor MightyChainTest to have more consistent asserts
Vylantze
committed
3c8191e
Move some functions out of BraveChainHandler into Utils. Write tests for BraveChainHandler and Utils
Vylantze
committed
19a92e8
Add CardType mapping function in Utils
Vylantze
committed
2bff158
Add class and tests for avoiding chains.
Vylantze
committed
1399922
Filter out unknown cards, since they will be generally unable to be read or stunned.
Vylantze
committed
3acaab7
Refactor names of classes
Vylantze
committed
ba6fc7a

Commits on Sep 2, 2025

Commits on Sep 3, 2025

Clean up unused variables. Make sure that Always uses the correct localization
Vylantze
committed
48f9d2e
Hide 'Always' unless Chain Priority is on
Vylantze
committed
0ec0101
Add caching for MightChain checks
Vylantze
committed
390fa42
Change logic of AvoidChain to attempt to make the consecutive cards from different servants.
Vylantze
committed
50a1ab0
Add handling for Avoid in ColorChainHandler
Vylantze
committed
9a46c34
Extract AvoidBraveChain logic to Utils file
Vylantze
committed
0b65233
Add AvoidBraveChain to MightyChainHandler
Vylantze
committed
106f5f6
Prevent the forcing of BraveChains if BraveChainEnum is set to None
Vylantze
committed
812960b
Change the behavior when dealing with forcedBraveChain and BraveChainEnum.Always.
Vylantze
committed
1d746a7
Add new tests. Fix bug in getBraveChainFieldSlot
Vylantze
committed
20bf2d3
Add more test cases for Utils
Vylantze
committed
c515a9d
Fix edge case for getCardsForAvoidBraveChain to maintain card order. Add more tests for Utils
Vylantze
committed
9a60da9

Commits on Sep 4, 2025

Commits on Sep 6, 2025

Add more handling for Unknown cards
Vylantze
committed
140818c
Add CardTypeEnum.Unknown tests
Vylantze
committed
8b4a3ac
Use more appropriate name for unknown filtered cards
Vylantze
committed
0fcc419
Ensure that 5 cards are always returned (even if there is Unknown)
Vylantze
committed
153e008
Add tests for AvoidChain and BraveChain
Vylantze
committed
728f839
Add tests for ColorChain and MightyChain for Unknown handling
Vylantze
committed
fd9e89d
Add tests for all BraveChainEnums in ColorChainTest.
Vylantze
committed
7dfb83a
Fix bug where ColorChain was not handling Avoid properly
Vylantze
committed
86e4706

Commits on Sep 7, 2025

Change AttackUtils to object
Vylantze
committed
8832a50
Change AvoidChainHandler to object
Vylantze
committed
28f4a5a
Change BraveChainHandler to object
Vylantze
committed
6c5033b
Change ColorChainHandler to object
Vylantze
committed
12e0562
Change MightyChainHandler to object
Vylantze
committed
886ff8d
Clean up unused imports and styling warnings
Vylantze
committed
fcbb00d
Change CardChainPriorityHandler to an object as well
Vylantze
committed
15995dc
Change AttackPriorityHandler to object
Vylantze
committed
4db66bb
Clean up unused imports
Vylantze
committed
d79125f
Change ApplyBraveChains to object
Vylantze
committed
d7c39be
Merge branch 'convert-classes-to-objects' into basic-mighty-chain
Vylantze
committed
f70cc78
Add NP detection system using faces
Vylantze
committed
11b03db

Commits on Sep 8, 2025

Commits on Sep 9, 2025

Commits on Sep 10, 2025

Only use detected exclusively for spamNPs.
Vylantze
committed
be28269
Revert the additional checks
Vylantze
committed
aece22b

Commits on Sep 17, 2025

Update documentation (part 1)
Vylantze
committed
8b8ea2f
Update images with transparency
Vylantze
committed
093d753
Update documentation (part 2)
Vylantze
committed
8ab1541
Readd forceBraveChain so that in the case where there is no Brave Chain available, 'Always' will return a valid chain
Vylantze
committed
08fe2fd
Add encasing box around advanced note
Vylantze
committed
0cd49f0
Update advanced note
Vylantze
committed
81ac38c

Commits on Sep 18, 2025

Update documentation part 3
Vylantze
committed
b1a0302
Update documentation part 4
Vylantze
committed
e417a8e

Commits on Sep 21, 2025

Fix bug with single card before NP + 1 NP usage. Add test case for it.
Vylantze
committed
d1852b8
Add more tests.
Vylantze
committed
b3a7dcc

Commits on Oct 6, 2025

Commits on Oct 7, 2025

Update with a comment on the redundancy of the defaultOrder.
Vylantze
committed
160b720

Commits on Dec 5, 2025

Force rebuild
Vylantze
committed
8c3d185

Commits on Dec 22, 2025

Merge branch 'master' into basic-mighty-chain
Vylantze
authored
4704264
Fix merge conflicts
Vylantze
committed
e4f7a7a

Commits on Dec 25, 2025

Merge remote-tracking branch 'Fate-Grand-Automata/master' into basic-mighty-chain
Vylantze
committed
a235832

Commits on Mar 27, 2026

Merge branch 'master' into basic-mighty-chain
ArthurKun21
authored
ae70eea

Commits on Apr 10, 2026

Merge remote-tracking branch 'Fate-Grand-Automata/master' into basic-mighty-chain
Vylantze
committed
3297d0b

Commits on Jun 15, 2026

Merge branch 'master' into basic-mighty-chain
ArthurKun21
authored
c6faa5b