Skip to content

Remove the values from the AttributeError message#1126

Open
baldurh wants to merge 1 commit into
FactoryBoy:masterfrom
baldurh:remove-values-from-error-message
Open

Remove the values from the AttributeError message#1126
baldurh wants to merge 1 commit into
FactoryBoy:masterfrom
baldurh:remove-values-from-error-message

Conversation

@baldurh

@baldurh baldurh commented Jun 12, 2025

Copy link
Copy Markdown

Fixes #1125

Changes the AttributeError message in Resolver.__getattr__ so that it does not include the object values.

@kingbuzzman kingbuzzman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baldurh

baldurh commented Jun 18, 2025

Copy link
Copy Markdown
Author

@kingbuzzman thanks for reviewing this. What else is needed for getting this in?

@kingbuzzman

Copy link
Copy Markdown
Contributor

for @rbarrois to have some time 🤣😇 🤞

@kingbuzzman

Copy link
Copy Markdown
Contributor

I currently got 2 PRs open, for about a month now, he's usually around, he must be really busy.. him and @francoisfreitag

@baldurh

baldurh commented Jun 18, 2025

Copy link
Copy Markdown
Author

Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Factory Boy stringifies models during factory initialisations with Trait params

2 participants