Skip to content

yang: Fix pyang errors in frr-bgp-common-structure.yang#22453

Merged
mjstapp merged 1 commit into
FRRouting:masterfrom
y-bharath14:srib-yang-Ver18
Jun 24, 2026
Merged

yang: Fix pyang errors in frr-bgp-common-structure.yang#22453
mjstapp merged 1 commit into
FRRouting:masterfrom
y-bharath14:srib-yang-Ver18

Conversation

@y-bharath14

Copy link
Copy Markdown
Contributor

Fix pyang errors in frr-bgp-common-structure.yang

frr-bgp-common-structure.yang:64: error: RFC 8407: 4.8: statement "revision" must have a "reference" substatement
frr-bgp-common-structure.yang:76: error: RFC 8407: 4.14: statement "choice" must have a "description" substatement
frr-bgp-common-structure.yang:110: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-bgp-common-structure.yang:111: error: RFC 8407: 4.14: statement "container" must have a "description" substatement
frr-bgp-common-structure.yang:139: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-bgp-common-structure.yang:140: error: RFC 8407: 4.14: statement "container" must have a "description" substatement
frr-bgp-common-structure.yang:198: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-bgp-common-structure.yang:199: error: RFC 8407: 4.14: statement "container" must have a "description" substatement
frr-bgp-common-structure.yang:224: error: RFC 8407: 4.14: statement "choice" must have a "description" substatement
frr-bgp-common-structure.yang:274: error: RFC 8407: 4.14: statement "choice" must have a "description" substatement
frr-bgp-common-structure.yang:383: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-bgp-common-structure.yang:387: error: RFC 8407: 4.14: statement "list" must have a "description" substatement
frr-bgp-common-structure.yang:410: error: RFC 8407: 4.14: statement "container" must have a "description" substatement
frr-bgp-common-structure.yang:412: error: RFC 8407: 4.14: statement "choice" must have a "description" substatement
frr-bgp-common-structure.yang:486: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-bgp-common-structure.yang:508: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-bgp-common-structure.yang:546: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-bgp-common-structure.yang:560: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-bgp-common-structure.yang:573: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-bgp-common-structure.yang:586: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-bgp-common-structure.yang:643: error: RFC 8407: 4.14: statement "choice" must have a "description" substatement
frr-bgp-common-structure.yang:728: error: RFC 8407: 4.14: statement "container" must have a "description" substatement
frr-bgp-common-structure.yang:729: error: RFC 8407: 4.14: statement "choice" must have a "description" substatement
frr-bgp-common-structure.yang:764: error: RFC 8407: 4.14: statement "container" must have a "description" substatement

Fix pyang errors in frr-bgp-common-structure.yang

Signed-off-by: y-bharath14 <y.bharath@samsung.com>
@greptile-apps

greptile-apps Bot commented Jun 23, 2026

Copy link
Copy Markdown

Greptile Summary

This PR fixes 24 pyang RFC 8407 compliance errors in yang/frr-bgp-common-structure.yang by adding required description substatements to grouping, container, choice, and list nodes, and a reference substatement to the revision block.

  • All 24 errors listed in the PR description are addressed; no pyang-required substatements appear to have been missed.
  • The reference "FRRouting"; value in the revision block is consistent with the pattern already used across 12 other FRR YANG modules.

Confidence Score: 5/5

Safe to merge — all changes are purely documentary metadata with no impact on runtime behavior or data model semantics.

Every change is a description or reference string added to YANG schema nodes. No leaf types, constraints, keys, or default values are touched, so existing implementations and generated code are unaffected.

No files require special attention.

Important Files Changed

Filename Overview
yang/frr-bgp-common-structure.yang Adds description and reference substatements to fix all 24 RFC 8407 pyang compliance errors; purely documentary, no functional logic changed.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[pyang lint run] -->|RFC 8407 errors| B[frr-bgp-common-structure.yang]
    B --> C[revision 2019-12-03\nmissing reference]
    B --> D[grouping nodes\nmissing description]
    B --> E[container nodes\nmissing description]
    B --> F[choice nodes\nmissing description]
    B --> G[list nodes\nmissing description]
    C -->|add reference FRRouting| H[Fixed]
    D -->|add description| H
    E -->|add description| H
    F -->|add description| H
    G -->|add description| H
    H -->|pyang clean| I[RFC 8407 compliant]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[pyang lint run] -->|RFC 8407 errors| B[frr-bgp-common-structure.yang]
    B --> C[revision 2019-12-03\nmissing reference]
    B --> D[grouping nodes\nmissing description]
    B --> E[container nodes\nmissing description]
    B --> F[choice nodes\nmissing description]
    B --> G[list nodes\nmissing description]
    C -->|add reference FRRouting| H[Fixed]
    D -->|add description| H
    E -->|add description| H
    F -->|add description| H
    G -->|add description| H
    H -->|pyang clean| I[RFC 8407 compliant]
Loading

Reviews (1): Last reviewed commit: "yang: Fix pyang errors in frr-bgp-common..." | Re-trigger Greptile

@y-bharath14

Copy link
Copy Markdown
Contributor Author

ci:rerun

@mjstapp mjstapp merged commit 0a3e71b into FRRouting:master Jun 24, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants