zebra: remove unused snprintf

[iurmanj6WIND]

Commit aa30079 ("zebra: convert zebra_neigh hashes to typesafe") replaced a call to zebra_neigh_db_create() by zebra_neigh_db_init(). As a result, the last snprintf becomes useless. Let's remove it.

[greptile-apps]

Greptile Summary

Removes a dead snprintf call in zebra_evpn_add() that populated a buffer string used solely to name the neighbor hash table. A previous commit (aa30079) replaced zebra_neigh_db_create(buffer) with zebra_neigh_db_init(zevpn->neigh_table), which takes no name argument, leaving the snprintf result unread.

• The removed line formatted \"Zebra EVPN Neighbor Table vni: %u\" into buffer, which is now only consumed by zebra_mac_db_create(buffer) on the line above — that remaining snprintf at line 1054 is still correct and untouched.
• The change has no functional impact; it is purely a dead-code cleanup.

Confidence Score: 5/5

Safe to merge — removes a single unreachable snprintf with no side effects.

The deleted line wrote into a local stack buffer that was never subsequently read; the zebra_neigh_db_init call that replaced the old zebra_neigh_db_create(buffer) takes no name argument. The only other consumer of buffer in the same function is the MAC-table snprintf on the line immediately above, which is untouched. There is no functional change and no risk of regression.

No files require special attention.

Important Files Changed

Filename	Overview
zebra/zebra_evpn.c	Removes one unused snprintf call; the remaining snprintf for the MAC table is unaffected and correct.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[zebra_evpn_add] --> B["snprintf buffer\nZebra EVPN MAC Table vni"]
    B --> C[zebra_mac_db_create buffer]
    C --> F[zevpn->mac_table]
    A --> D["snprintf buffer (REMOVED)\nZebra EVPN Neighbor Table vni\nwas unused after db_init migration"]
    style D stroke-dasharray: 5 5
    A --> E["zebra_neigh_db_init\nno name arg needed"]
    E --> G[zevpn->neigh_table]

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[zebra_evpn_add] --> B["snprintf buffer\nZebra EVPN MAC Table vni"]
    B --> C[zebra_mac_db_create buffer]
    C --> F[zevpn->mac_table]
    A --> D["snprintf buffer (REMOVED)\nZebra EVPN Neighbor Table vni\nwas unused after db_init migration"]
    style D stroke-dasharray: 5 5
    A --> E["zebra_neigh_db_init\nno name arg needed"]
    E --> G[zevpn->neigh_table]

Loading

_{Reviews (1): Last reviewed commit: "zebra: remove unused snprintf" | Re-trigger Greptile}

[riw777]

looks good