fix: scope SAT cookie to current subdomain, not broad .osaas.io domain (closes #33)#36
Open
LucasMaupin wants to merge 1 commit into
Open
fix: scope SAT cookie to current subdomain, not broad .osaas.io domain (closes #33)#36LucasMaupin wants to merge 1 commit into
LucasMaupin wants to merge 1 commit into
Conversation
closes #33) Remove the explicit `domain=.osaas.io` attribute from the SAT cookie set in authenticateWithOpenLive(). Without an explicit domain, browsers scope the cookie to the exact hostname (e.g. open-live-studio.tenant.osaas.io), preventing other co-tenant applications on *.osaas.io from reading the bearer token. isOnOsc() is unchanged — it still detects OSC by checking .osaas.io suffix. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
domain=.osaas.ioattribute from the SAT bearer token cookie set inauthenticateWithOpenLive()insrc/lib/sat.ts.document.location.hostname(e.g.open-live-studio.tenant.osaas.io), preventing any other co-tenant application on*.osaas.iofrom reading the token viadocument.cookie.isOnOsc()is unchanged — it still detects the OSC environment by checking that the hostname ends with.osaas.io.Closes #33