Skip to content

Use timeSpent instead of _readElapsed to decide if we should log or not #2683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aldo-expensify merged 1 commit into from
Jul 16, 2026
Merged

Use timeSpent instead of _readElapsed to decide if we should log or not #2683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sqlitecluster/SQLite.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@ bool SQLite::read(const string& query, const map<string, Parameter>& params, SQR

// If we're not inside a transaction, this doesn't get added to our normal transaction timing.
// This log line will happen a lot. Let's log only when it takes more than 100ms to complete.
if (!_insideTransaction && _readElapsed > 100'000) {
if (!_insideTransaction && timeSpent > 100'000) {
SINFO("Read with auto-transaction timing info", {
{"totalTransactionElapsed", to_string(timeSpent / 1000)},
});
Expand Down
Loading