chore(clang): upgrade to clang 22#2679
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d5e34203a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Download binaries | ||
| uses: ./.github/actions/composite/download-binaries |
There was a problem hiding this comment.
Restore the checkout before using the local action
On tag/release runs this job now starts with uses: ./.github/actions/composite/download-binaries, but the preceding checkout was removed and each GitHub Actions job gets a fresh workspace. Without checking out the repository first, the runner cannot resolve the local composite action path, so the release upload job fails before restoring, stripping, or uploading the Bedrock binary.
Useful? React with 👍 / 👎.
Details
As with the other PRs, this upgrades this repo to clang 22. The only functional change in this repo is the switch from
atomic_storeandatomic_loadtoatomicwith.load(), the previous pattern was deprecated in c++-20, but not marked deprecated until we upgraded fromlibstdc++-13-devtolibstdc++-16-devFixed Issues
Related https://github.com/Expensify/Expensify/issues/659917
Tests
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes