Exclude volatile per-request fields from Jobs crash blacklist

[MelvinBot]

Details

The Jobs plugin's crash-command blacklist ("poison-pill" protection) was effectively broken. In BedrockJobsCommand::peek, crashIdentifyingValues was populated with every request field:

for (const auto& name : request.nameValueMap) {
    crashIdentifyingValues.insert(name.first);
}

That set included requestID, which is unique for every request. Since BedrockServer::_wouldCrash requires an exact match on every stored key/value (skipping only Content-Length), a single blacklist entry could never match a future command — no two requests share a requestID.

This change keys crashIdentifyingValues on an explicit whitelist of the fields that semantically identify a Jobs command — name and data — instead of a blacklist of volatile fields. This is the correct approach given how BedrockServer::_wouldCrash handles multiple crashes of the same methodLine:

• If a command crashes with more than one distinct set of identifying values, _wouldCrash assumes we've already lost more than one node and blocks the command for everyone.
• With a whitelist of just name/data, the same command crashing twice records the same identifying set (one entry → only that command is blocked), while two genuinely different commands crashing records two sets → the block-everyone safeguard fires as intended.
• A blacklist that left in non-identifying fields (e.g. jobID, priority) would have recorded a different set on each crash of the same command and wrongly tripped the block-everyone path.

Fixed Issues

https://github.com/Expensify/Expensify/issues/656214

Tests

• Updated the in-process unit test test/tests/jobs/CrashIdentifyingValuesTest.cpp to assert only name and data (and their values) are kept and every other field is dropped, including present-but-non-identifying fields like jobID/priority.
• just docker rebuild-cpp — Bedrock + Auth compile cleanly with -Wall -Werror.
• ./test -only JobsCrashIdentifyingValues → Passed: 2, Failed: 0.
• ./test -only CreateJob (server-based, exercises the peek() path) → Passed: 17, Failed: 0.

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".

---

Internal Testing Reminder: when changing bedrock, please compile auth against your new changes

[tylerkaraszewski]

Instead of doing the AI thing where it adds 50 lines to make a 3 line change, I would simply change the loop removed here with:

crashIdentifyingValues.insert("name");
crashIdentifyingValues.insert("data");

No changes to the .h file, -3/+2 here.

[tylerkaraszewski]

I find this entire test quite useless. It inserts two items in a map and then spends 74 lines asserting that the map contains those two items. We already know that maps work without this test class.