[No QA] [Snyk] Security upgrade svgo from 4.0.0 to 4.0.2#96749
[No QA] [Snyk] Security upgrade svgo from 4.0.0 to 4.0.2#96749MelvinBot wants to merge 4 commits into
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-SVGO-18170231
|
This is a patch upgrade from
No breaking changes are documented in this version range. Source: GitHub Releases
|
|
@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa19388168
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "storybook": "10.4.6", | ||
| "storybook-react-rsbuild": "^3.3.4", | ||
| "svgo": "^4.0.0", | ||
| "svgo": "^4.0.2", |
There was a problem hiding this comment.
Update the lockfile with the svgo bump
This change only updates package.json, but package-lock.json still declares the root svgo dependency as ^4.0.0 and locks node_modules/svgo to 4.0.0 (package-lock.json:280, package-lock.json:39340). In any workflow where the node_modules cache is missed, .github/actions/composite/setupNode/action.yml runs npm ci, and npm's ci docs state that mismatched package/lock dependencies exit with an error instead of updating the lock (https://docs.npmjs.com/cli/v8/commands/npm-ci); even when installs are not rerun, the committed lockfile still leaves the vulnerable 4.0.0 package selected. Please regenerate and commit package-lock.json for svgo@4.0.2 with this bump.
Useful? React with 👍 / 👎.
|
🤖 Fixed the failing checks. Root cause: This Snyk commit bumped Fix: Synced
This is exactly the change |
|
Fixed the failing Verify Javascript Action Builds check. Root cause: This PR bumps Fix: Ran |
|
No failing checks remain. The previously-failing Verify Javascript Action Builds ( |
|
The What's failing: Why: Recommended fix: Bring the branch up to date with |
…onger flags "notation"
|
The failing check is unrelated to this PR — it's an infrastructure flake, not a code or test failure. What failed: Only
The Blacksmith runner dropped mid-run — the test job never reported a test result. Shards 2–8 of the same suite all passed, and every other check (ESLint, typecheck, Storybook, perf, Snyk, etc.) is green. Why it's not related to your changes: This PR only bumps Recommended action: Re-run the failed job — |
|
If this requires C+ review, I can help. |
Codecov Report✅ All modified and coverable lines are covered by tests. |
|
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Explanation of Change
Fixed Issues
$ #96750
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari