fix: iOS Share to Expensify screen does not close when swiping back#96581
Open
samranahm wants to merge 1 commit into
Open
fix: iOS Share to Expensify screen does not close when swiping back#96581samranahm wants to merge 1 commit into
samranahm wants to merge 1 commit into
Conversation
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
7 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an iOS-only navigation regression in the native Share extension flow by ensuring the “Share to Expensify” modal can be dismissed with the back-swipe gesture, aligning behavior with expected iOS UX and the linked issue.
Changes:
- Enables
gestureEnabledfor theSHARE_MODAL_NAVIGATORscreen so the swipe-back gesture dismisses the Share modal on iOS. - Keeps existing full-screen modal configuration (no animation, full-height web styling) while adding gesture support specifically for the Share modal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #94908
PROPOSAL: #94908 (comment)
Tests
Offline tests
Same as test
QA Steps
Same as test
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android.Native.mp4
Android: mWeb Chrome
N/A Share sheet is native-only
iOS: Native
IOS.Native.mp4
iOS: mWeb Safari
N/A Share sheet is native-only
MacOS: Chrome / Safari
N/A Share sheet is native-only