feat: Show the Workspace name beside the room name in Search results by nkdengineer · Pull Request #96574 · Expensify/App

nkdengineer · 2026-07-21T04:49:44Z

Explanation of Change

Fixed Issues

$ #96151
PROPOSAL: #96151 (comment)

Tests

Create some workspaces
Open search router
Enter in:admins
Verify that the workspace name and workspace avatar are displayed on the right of the suggestion item

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-07-21T06:03:50Z

@dubielzyk-expensify @huult One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-07-21T06:04:36Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...Search/SearchList/ListItem/SearchQueryListItem.tsx	`95.65% <100.00%> (+0.19%)`	⬆️
src/hooks/useAutocompleteSuggestions.ts	`63.31% <100.00%> (+0.56%)`	⬆️
src/components/Search/SearchAutocompleteList.tsx	`92.82% <0.00%> (-0.45%)`	⬇️
... and 12 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cfff42a41d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-21T06:09:07Z

+                    rightElement: workspaceIcon ? (
+                        <AvatarWithTextCell
+                            reportName={workspaceIcon.name}
+                            icon={workspaceIcon}
+                            isLargeScreenWidth
+                        />
+                    ) : undefined,


Add workspace labels to room result rows

This only attaches the workspace cell to autocompleteSuggestions, so it appears for in: filter suggestions but not for the normal search switcher result rows: typing a room name such as admins still builds nextStyledRecentReports above and renders those rows through BareUserListItem without any rightElement. In the duplicate #admins scenario, users who search by the room name still see indistinguishable room results unless they know to type the in: prefix, so the disambiguation should also be propagated to the report result options.

Useful? React with 👍 / 👎.

cc @nkdengineer

huult · 2026-07-21T12:31:03Z

@nkdengineer Once your screenshots are ready, please tag the Product/Design team to review them.

huult · 2026-07-21T12:31:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-07-21T23:24:08Z

🚧 dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here.

nkdengineer added 4 commits July 16, 2026 22:37

add workspace name to in suggestion

8d1de7b

Merge branch 'main' into fix/96151

0f4a3ea

fix long workspace style

0c0029c

fix max width right element

cfff42a

melvin-bot Bot assigned nkdengineer Jul 21, 2026

nkdengineer marked this pull request as ready for review July 21, 2026 06:03

nkdengineer requested review from a team as code owners July 21, 2026 06:03

melvin-bot Bot requested review from dubielzyk-expensify, huult and trjExpensify and removed request for a team July 21, 2026 06:03

chatgpt-codex-connector Bot reviewed Jul 21, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Show the Workspace name beside the room name in Search results#96574

feat: Show the Workspace name beside the room name in Search results#96574
nkdengineer wants to merge 4 commits into
Expensify:mainfrom
nkdengineer:fix/96151

nkdengineer commented Jul 21, 2026

Uh oh!

melvin-bot Bot commented Jul 21, 2026

Uh oh!

codecov Bot commented Jul 21, 2026 •

edited by github-actions Bot

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jul 21, 2026

Uh oh!

huult Jul 21, 2026

Uh oh!

huult commented Jul 21, 2026 •

edited

Loading

Uh oh!

huult commented Jul 21, 2026

Uh oh!

github-actions Bot commented Jul 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

nkdengineer commented Jul 21, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 21, 2026

Uh oh!

codecov Bot commented Jul 21, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

huult Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

huult commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

huult commented Jul 21, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Jul 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Jul 21, 2026 •

edited by github-actions Bot

Loading

huult commented Jul 21, 2026 •

edited

Loading